Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[iOS TextInput] Disables system keyboard for TextInputType.none #26979

Merged
fluttergithubbot merged 2 commits into from
Jun 29, 2021
Merged

[iOS TextInput] Disables system keyboard for TextInputType.none #26979

fluttergithubbot merged 2 commits into from
Jun 29, 2021

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Jun 26, 2021

Continuation of #26773
/cc @jpnurmi

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jun 26, 2021
jpnurmi
jpnurmi reviewed Jun 26, 2021
View reviewed changes
shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm Outdated
int _textInputClient;
const char* _selectionAffinity;
FlutterTextRange* _selectedTextRange;
UIInputViewController* _inputViewcController;
Copy link
Member

@jpnurmi jpnurmi Jun 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small typo

@jpnurmi
Copy link
Member

jpnurmi commented Jun 26, 2021 •
edited
Loading

Thank you, works great!

justinmc
justinmc approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Does Android already disable the system keyboard?

@LongCatIsLooong
Copy link
Contributor Author

LongCatIsLooong commented Jun 28, 2021

@justinmc the Android PR is here: #26585

@chunhtai
Copy link
Contributor

chunhtai commented Jun 28, 2021

I assume developer uses this for custom keyboard? can you double check whether using the custom keyboard with the voice over on still pronounce feedback when you type?

@LongCatIsLooong
Copy link
Contributor Author

LongCatIsLooong commented Jun 28, 2021

@chunhtai I couldn't test voiceover on simulator (but the accessibility inspector shows the text field as a button, nothing seems to change in the inspector when I disable/enable the system keyboard). On device I don't have ways to enter new text but it pronounces the current content.

@chunhtai
Copy link
Contributor

chunhtai commented Jun 28, 2021

@LongCatIsLooong, the simulator is fine. For device, can you try to simulate a custom keyboard? for example, have a button that insert a character into the textfield when pressed, the voiceover should announce the character that got inserted

@LongCatIsLooong
Copy link
Contributor Author

LongCatIsLooong commented Jun 28, 2021 •
edited
Loading

Wouldn't the button steal the focus from the text field in that case? Oh let me try using the ontapped callback.

@chunhtai
Copy link
Contributor

chunhtai commented Jun 28, 2021

@LongCatIsLooong yes, It is the same for for system keyboard, too. TextField announce the key feedback even when the keyboard strokes have the focus.

@LongCatIsLooong
Copy link
Contributor Author

LongCatIsLooong commented Jun 28, 2021

Ok yeah It does pronounce the new character if I focus the text field first.

chunhtai
chunhtai approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongCatIsLooong LongCatIsLooong added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 29, 2021
@fluttergithubbot fluttergithubbot merged commit c03f144 into flutter:master Jun 29, 2021
@jpnurmi jpnurmi mentioned this pull request Jun 29, 2021
Merged
14 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 29, 2021
@engine-flutter-autoroll
c03f144 [iOS TextInput] Disables system keyboard for TextInputType.no…
de37153 
…ne (flutter/engine#26979)
@LongCatIsLooong LongCatIsLooong deleted the disables-system-keyboard-for-keyboardtypenone branch June 29, 2021 18:03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 29, 2021
@engine-flutter-autoroll
c03f144 [iOS TextInput] Disables system keyboard for TextInputType.no…
66c2f2b 
…ne (flutter/engine#26979)
zanderso pushed a commit to flutter/flutter that referenced this pull request Jun 29, 2021
@engine-flutter-autoroll
Roll Engine from 56884b7 to 2384128 (5 revisions) (#85564)
dcd4886 
* b035192 Roll Dart SDK from e6e47f919791 to 59f9594aed9a (1 revision) (flutter/engine#27032)

* 9e69740 [refactor] Migrate to View.focus.*. (flutter/engine#27005)

* 9928f4f Android: add support for TextInputType.none (flutter/engine#26585)

* c03f144 [iOS TextInput] Disables system keyboard for TextInputType.none (flutter/engine#26979)

* 2384128 Roll Skia from 1df8756419ee to 4716a7681e4a (7 revisions) (flutter/engine#27035)
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
@LongCatIsLooong @moffatman
[iOS TextInput] Disables system keyboard for TextInputType.none (flut…
e45c9bd 
…ter#26979)
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@LongCatIsLooong
[iOS TextInput] Disables system keyboard for TextInputType.none (flut…
0b2df88 
…ter#26979)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@jpnurmi jpnurmi jpnurmi left review comments

@justinmc justinmc justinmc approved these changes

@chunhtai chunhtai chunhtai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-ios waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LongCatIsLooong @jpnurmi @chunhtai @justinmc @fluttergithubbot