This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Issues/80711 reland #26813
Merged
Issues/80711 reland #26813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
reviewed
Jun 17, 2021
| CGRect result; | ||
| const SkRect& rect = _semanticsObject.node.rect; | ||
| float x, y, width, height; | ||
| float scrollExtentMax = _semanticsObject.node.scrollExtentMax == INFINITY |
Member
There was a problem hiding this comment.
You shouldn't check equality against INFINITY, there is the isfinite function https://en.cppreference.com/w/c/numeric/math/isfinite
Comment on lines
233
to
236
| x = rect.x(); | ||
| y = rect.y(); | ||
| width = rect.width(); | ||
| height = rect.height() + scrollExtentMax; |
Member
There was a problem hiding this comment.
nit: I liked the CGRectMake calls better fwiw. It's a bit easier to maintain since it enforces all things are set before returning the result.
|
|
||
| namespace { | ||
|
|
||
| constexpr float kScrollExtentMaxForInf = 1000; |
Member
There was a problem hiding this comment.
It's probably worth commenting why 1000. That sounds like a small number, it's hard for me to know if it's adequate.
| w * effectivelyScale, h * effectivelyScale))); | ||
| XCTAssertTrue(CGSizeEqualToSize( | ||
| scrollable.contentSize, | ||
| CGSizeMake(w * effectivelyScale, (h + 1000 + scrollPosition) * effectivelyScale))); |
Member
There was a problem hiding this comment.
Pull out 1000 into a variable, name it so people have a chance of finding the const where it comes from.
chunhtai
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
chunhtai
force-pushed
the
issues/80711-reland
branch
from
86e6a53 to
d6feb68
Compare
chunhtai
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 20, 2021
wqyfavor
pushed a commit
to wqyfavor/engine
that referenced
this pull request
Jun 21, 2021
chunhtai
added a commit
to chunhtai/engine
that referenced
this pull request
Jun 21, 2021
This reverts commit 53e4dcf.
chunhtai
added a commit
that referenced
this pull request
Jun 21, 2021
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
This reverts commit 53e4dcf.
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
This reverts commit 53e4dcf.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous pr was reverted due to a internal test failure
the issue was the flutterscrollablesemanticsobject does not handle the case where scrollextent can be infinity. The fix is in the second commit.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.