Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Linux: add support for TextInputType.none #26574

Merged
robert-ancell merged 2 commits into from
Jun 16, 2021
Merged

Linux: add support for TextInputType.none #26574

robert-ancell merged 2 commits into from
Jun 16, 2021

Conversation

@jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jun 3, 2021

TextInputType.none makes it possible to disable the virtual keyboard for certain TextFields, and lays the foundations for custom in-app virtual keyboards (flutter/flutter#76072).

Ref: flutter/flutter#83567

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jpnurmi
Linux: add support for TextInputType.none
8448c56 
TextInputType.none makes it possible to disable the virtual keyboard
for certain TextFields, and lays the foundations for custom in-app
virtual keyboards (flutter/flutter#76072).

Ref: flutter/flutter#83567
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 3, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Jun 3, 2021
@jpnurmi
Copy link
Member Author

jpnurmi commented Jun 3, 2021 •
edited
Loading

Minimal example: https://github.com/jpnurmi/text_input_type_none_example (requires flutter/flutter#83974 for the enum value)

text-input-type-none.mp4

@jpnurmi jpnurmi mentioned this pull request Jun 4, 2021
Merged
14 tasks
@jpnurmi
Copy link
Member Author

jpnurmi commented Jun 4, 2021

Is there any reasonable way to test this?

@chinmaygarde chinmaygarde requested review from gspencergoog and robert-ancell and removed request for gspencergoog June 10, 2021 20:13
@gspencergoog
Copy link
Contributor

gspencergoog commented Jun 10, 2021

/cc @cbracken

robert-ancell
robert-ancell reviewed Jun 10, 2021
View reviewed changes
@robert-ancell
Copy link
Contributor

robert-ancell commented Jun 10, 2021

Is there any reasonable way to test this?

We don't currently have any test framework for testing at the GTK level.

@jpnurmi jpnurmi mentioned this pull request Jun 15, 2021
Merged
8 tasks
robert-ancell
robert-ancell approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-ancell robert-ancell merged commit df3aa14 into flutter:master Jun 16, 2021
@jpnurmi jpnurmi deleted the linux-text-input-type-none branch June 16, 2021 06:21
cbracken
cbracken reviewed Jun 16, 2021
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay -- thanks for adding!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

2 more reviewers

@cbracken cbracken cbracken left review comments

@robert-ancell robert-ancell robert-ancell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-linux

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpnurmi @gspencergoog @robert-ancell @cbracken