This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Warn if DartWrappables do not get disposed before GC #26375
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
When https://github.com/dart-lang/sdk/issues/45455 lands, this code should be removed and replaced with pure Dart code using finalizers. |
Contributor
Author
|
I think we'd want to measure performance there, right? Specifically, we'd want to know what overhead is incurred by adding a Dart finalizer to a hot object like Picture. |
Contributor
|
I'm going to close this PR since it is marked work-in-progress but hasn't been touched for a long time. Please open a new PR when ready. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP