This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fuchsia: Only send different ViewProperties #26170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chaselatta
approved these changes
May 17, 2021
Contributor
chaselatta
left a comment
chaselatta
left a comment
There was a problem hiding this comment.
Couple of small questions but overall looks good.
|
|
||
| void ViewHolder::set_size(const SkSize& size) { | ||
| if (size.width() > 0.f && size.height() > 0.f) { | ||
| if (view_properties_.bounding_box.max.x != size.width()) { |
Contributor
There was a problem hiding this comment.
Should we be concerned with small rounding differences here since these are working on floats? If I change my width from 100.0 to 100.001 this won't update. I'm not sure if we really want to update the view properties if it is that small of a change but it is something we should be aware of.
Contributor
Author
There was a problem hiding this comment.
This should work fine with a change that small, it would start to break down with change smaller that 1e-7 but other places in the flutter engine would have that problem too
| view_properties_.inset_from_min.y = occlusion_hint.fTop; | ||
| view_properties_.inset_from_max.x = occlusion_hint.fRight; | ||
| view_properties_.inset_from_max.y = occlusion_hint.fBottom; | ||
| if (view_properties_.inset_from_min.x != occlusion_hint.fLeft) { |
Contributor
There was a problem hiding this comment.
Same question here about float equality.
Contributor
Author
There was a problem hiding this comment.
It's also OK here. We want the code to trigger if even the smallest change is detected (so anything larger than 1e-7 for a float)
arbreng
force-pushed
the
fuchsia-child-view-depth
branch
from
b40e86a to
a942456
Compare
arbreng
force-pushed
the
fuchsia-child-view-depth
branch
from
a942456 to
ba6625d
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 17, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 17, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 17, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 17, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 18, 2021
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
May 19, 2021
* 98068f1 fuchsia: Only send different ViewProperties (flutter/engine#26170) * 5e487ba Roll Skia from c1f641104531 to 469531234936 (4 revisions) (flutter/engine#26197) * 4cab492 Add image generator registry (flutter/engine#25987) * c753c24 Roll Fuchsia Linux SDK from l6XmTSLnt... to AUWVgDkx6... (flutter/engine#26201) * 75a7812 Reland outputs a json version of the package manifest. (flutter/engine#26163) * b5dc598 Roll Skia from 469531234936 to 5b38536d76ae (7 revisions) (flutter/engine#26202) * fb91366 [icu] Upgrade ICU to 69.1, the same commit used by Chromimum latest (flutter/engine#26200) * 62e0951 Prepare to move --delete-tostring-package-uri option to Dart SDK (flutter/engine#26196) * 156c2be Web ImageFilter.matrix support (flutter/engine#25982) * c30de25 Roll Skia from 5b38536d76ae to 2fed9f62d29a (7 revisions) (flutter/engine#26206) * 7ef42f1 Roll Fuchsia Mac SDK from KmSY84b_E... to 7WNQRHsHN... (flutter/engine#26207) * 8bba964 Add more diagrams for deferred components docs, fix alignment of existing one (flutter/engine#26209) * 391e22d Roll Dart SDK from 67be110b5ba8 to 510f26486328 (3 revisions) (flutter/engine#26212) * fa62ce0 Roll Skia from 2fed9f62d29a to e8cd0a54041e (2 revisions) (flutter/engine#26213) * 2029cba Roll Skia from e8cd0a54041e to 3d854bade6de (4 revisions) (flutter/engine#26216) * 9cd3c64 Roll Fuchsia Linux SDK from AUWVgDkx6... to boele8geO... (flutter/engine#26217) * 6ceab15 Roll Dart SDK from 510f26486328 to 13e329e614f2 (1 revision) (flutter/engine#26218) * f90698a Roll Fuchsia Mac SDK from 7WNQRHsHN... to F5TX4MaEg... (flutter/engine#26220) * b9d03fe Roll Skia from 3d854bade6de to 66125eac158d (1 revision) (flutter/engine#26221) * 849ce7e Roll Dart SDK from 13e329e614f2 to 2eea032403e2 (1 revision) (flutter/engine#26222) * ca89d69 Roll Skia from 66125eac158d to 5696bcd0f7f8 (1 revision) (flutter/engine#26223) * db7a3dc fuchsia: Fix occlusion_hint handling (flutter/engine#26208) * b875d99 Roll Skia from 5696bcd0f7f8 to bdfd77616177 (5 revisions) (flutter/engine#26224) * b67caca Roll Skia from bdfd77616177 to fb8d20befa8f (1 revision) (flutter/engine#26225) * 2398dea Revert Dart SDK to 67be110b5ba8fc84af5e7136389e52a13ccbc9d5 (flutter/engine#26232)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only send ViewProperties when they actually change, and send -1000 for the "depth" each time.
This fixes black screens on workstation.
Fixes: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=76358