Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@chaselatta
Copy link
Contributor

@chaselatta chaselatta commented May 14, 2021

Reland outputs a json version of the package manifest.

This patch is in preparation for incremental package serving from the engine repo.

fxbug.dev/76633
Previous attempt to land this patch was failing because I was generating the package manifest in the package's directory.

@google-cla google-cla bot added the cla: yes label May 14, 2021
@chaselatta chaselatta marked this pull request as draft May 14, 2021 22:36
@chaselatta chaselatta force-pushed the output-manifest-json2 branch 4 times, most recently from d8e7af7 to dcbe30b Compare May 17, 2021 16:54
@chaselatta chaselatta changed the title DO NOT COMMIT: reland output json manifest file in fuchsia_archive reland output json manifest file in fuchsia_archive May 17, 2021
@chaselatta chaselatta marked this pull request as ready for review May 17, 2021 16:55
This patch is in preparation for incremental package serving from the engine repo.

fxbug.dev/76633
Previous attempt to land this patch was failing because I was generating
the package manifest in the package's directory.
@chaselatta chaselatta force-pushed the output-manifest-json2 branch from dcbe30b to aecd87a Compare May 17, 2021 17:34
Copy link
Contributor

@chandarrengoog chandarrengoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chaselatta chaselatta merged commit 75a7812 into flutter:master May 17, 2021
@chaselatta chaselatta deleted the output-manifest-json2 branch May 17, 2021 20:21
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 17, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 17, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2021
zanderso pushed a commit to flutter/flutter that referenced this pull request May 19, 2021
* 98068f1 fuchsia: Only send different ViewProperties (flutter/engine#26170)

* 5e487ba Roll Skia from c1f641104531 to 469531234936 (4 revisions) (flutter/engine#26197)

* 4cab492 Add image generator registry (flutter/engine#25987)

* c753c24 Roll Fuchsia Linux SDK from l6XmTSLnt... to AUWVgDkx6... (flutter/engine#26201)

* 75a7812 Reland outputs a json version of the package manifest. (flutter/engine#26163)

* b5dc598 Roll Skia from 469531234936 to 5b38536d76ae (7 revisions) (flutter/engine#26202)

* fb91366 [icu] Upgrade ICU to 69.1, the same commit used by Chromimum latest (flutter/engine#26200)

* 62e0951 Prepare to move --delete-tostring-package-uri option to Dart SDK (flutter/engine#26196)

* 156c2be Web ImageFilter.matrix support (flutter/engine#25982)

* c30de25 Roll Skia from 5b38536d76ae to 2fed9f62d29a (7 revisions) (flutter/engine#26206)

* 7ef42f1 Roll Fuchsia Mac SDK from KmSY84b_E... to 7WNQRHsHN... (flutter/engine#26207)

* 8bba964 Add more diagrams for deferred components docs, fix alignment of existing one (flutter/engine#26209)

* 391e22d Roll Dart SDK from 67be110b5ba8 to 510f26486328 (3 revisions) (flutter/engine#26212)

* fa62ce0 Roll Skia from 2fed9f62d29a to e8cd0a54041e (2 revisions) (flutter/engine#26213)

* 2029cba Roll Skia from e8cd0a54041e to 3d854bade6de (4 revisions) (flutter/engine#26216)

* 9cd3c64 Roll Fuchsia Linux SDK from AUWVgDkx6... to boele8geO... (flutter/engine#26217)

* 6ceab15 Roll Dart SDK from 510f26486328 to 13e329e614f2 (1 revision) (flutter/engine#26218)

* f90698a Roll Fuchsia Mac SDK from 7WNQRHsHN... to F5TX4MaEg... (flutter/engine#26220)

* b9d03fe Roll Skia from 3d854bade6de to 66125eac158d (1 revision) (flutter/engine#26221)

* 849ce7e Roll Dart SDK from 13e329e614f2 to 2eea032403e2 (1 revision) (flutter/engine#26222)

* ca89d69 Roll Skia from 66125eac158d to 5696bcd0f7f8 (1 revision) (flutter/engine#26223)

* db7a3dc fuchsia: Fix occlusion_hint handling (flutter/engine#26208)

* b875d99 Roll Skia from 5696bcd0f7f8 to bdfd77616177 (5 revisions) (flutter/engine#26224)

* b67caca Roll Skia from bdfd77616177 to fb8d20befa8f (1 revision) (flutter/engine#26225)

* 2398dea Revert Dart SDK to 67be110b5ba8fc84af5e7136389e52a13ccbc9d5 (flutter/engine#26232)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants