This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[uwptool] Support lookup of full package name #26121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@clarkezone note that this is stacked on top of #26120, which should be reviewed first. Once that's done, I'll rebase this on top of it. Therefore, you only need to review the second commit in this patch. |
cbracken
changed the title
UWP apps must be launched using their package family name, but are uninstalled using their full package name. This patch updates the Application class to store both. Further, when launching UWP apps, we now do a lookup to verify the package exists before attempting to launch it.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2021
cbracken
pushed a commit
to flutter/flutter
that referenced
this pull request
May 13, 2021
* 7adb8de Roll Skia from 6b719c25cade to ca9f6a855071 (3 revisions) (flutter/engine#26127) * a1062aa [uwptool] Support lookup of full package name (flutter/engine#26121) * 01ce6a1 Get android_lint deps using gclient rather than pub. (flutter/engine#26106) * cba6c1e Use cached CanvasKit instance if available (flutter/engine#26059) * b0bb8ea Switch PlatformMessages to hold data in Mappings (flutter/engine#25867)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UWP apps must be launched using their package family name, but are
uninstalled using their full package name. This patch updates the
Application class to store both.
Further, when launching UWP apps, we now do a lookup to verify the
package exists before attempting to launch it.
Issue: flutter/flutter#81756
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.