Get android_lint deps using gclient rather than pub. #26106
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| return entry.name != 'archive' // contains nothing that ends up in the binary executable | ||
| && entry.name != 'file' | ||
| && entry.name != 'platform' | ||
| && entry.name != 'process'; |
There was a problem hiding this comment.
I wonder if this is safe - it seems like we might want to use entry.fullName.endsWith or something to avoid skipping over some random subdirectory of another thing we care about that happens to have a directory named file or platform or process.
There was a problem hiding this comment.
Oh I see, this class is only used for the Dart third party packages. Ok.
There was a problem hiding this comment.
Right. This only covers exactly third_party/pkg/process etc.
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM with nit about removing one of those issue links.
* 7adb8de Roll Skia from 6b719c25cade to ca9f6a855071 (3 revisions) (flutter/engine#26127) * a1062aa [uwptool] Support lookup of full package name (flutter/engine#26121) * 01ce6a1 Get android_lint deps using gclient rather than pub. (flutter/engine#26106) * cba6c1e Use cached CanvasKit instance if available (flutter/engine#26059) * b0bb8ea Switch PlatformMessages to hold data in Mappings (flutter/engine#25867)
2 participants
More work for flutter/flutter#82134
This PR also fixes Dart lints in android_lint.