This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use cached CanvasKit instance if available #26059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could be useful for hot restart or for DartPad.
flutter-dashboard
bot
added
the
platform-web
yjbanov
approved these changes
May 11, 2021
|
|
||
| @JS('window.flutterCanvasKit') | ||
| external set windowFlutterCanvasKit(CanvasKit value); | ||
| external CanvasKit? get windowFlutterCanvasKit; |
Contributor
There was a problem hiding this comment.
Should we use a more generic name so this method is compatible with Cobalt?
Contributor
Author
There was a problem hiding this comment.
I purposely left it open because it's unknown if we will need to call CanvasKitInit on the Cobalt implementation. So far now this is flutter-specific because it should be an already-initialized CanvasKit instance. If it turns out that the native CanvasKit instance is already initialized, we can rename this to be the same as the native CanvasKit object.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2021
cbracken
pushed a commit
to flutter/flutter
that referenced
this pull request
May 13, 2021
* 7adb8de Roll Skia from 6b719c25cade to ca9f6a855071 (3 revisions) (flutter/engine#26127) * a1062aa [uwptool] Support lookup of full package name (flutter/engine#26121) * 01ce6a1 Get android_lint deps using gclient rather than pub. (flutter/engine#26106) * cba6c1e Use cached CanvasKit instance if available (flutter/engine#26059) * b0bb8ea Switch PlatformMessages to hold data in Mappings (flutter/engine#25867)
johnpryan
added a commit
to dart-lang/dart-pad
that referenced
this pull request
May 17, 2021
* remove duplicate canvaskit.js files This is a workaround for #1860 until flutter/engine#26059 lands or we can switch to the HTML renderer in dart-services * simplify removeCanvaskit function
johnpryan
added a commit
to dart-lang/dart-pad
that referenced
this pull request
Nov 3, 2021
Engine commit: flutter/engine#26059 Flutter SDK commit: flutter/flutter@d9db3ea Commit is available on stable: arewethereyet d9db3ea6e6b1cccda5838b11c156595f109df68c Commit is merged into: origin/master origin/dev origin/beta origin/stable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we've already initialized CanvasKit, don't re-initialize it on hot restart.
Should help with dart-lang/dart-pad#1860
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.