Add dependency on Windows SDK CIPD package #26003
Conversation
|
The cppwinrt failure here is that cppwinrt can't handle paths that are longer than the Windows maximum path length of 260 characters. I was able to repro this locally by renaming a parent directory to something really long. Looking at how we can work around that. One option appears to be setting a particular registry key |
This should be supported with recent builds. https://github.com/microsoft/cppwinrt/blob/master/cppwinrt/app.manifest |
|
@kennykerr Thanks! I was able to repro the path failures on my desktop with version Still seeing a failure on the bot, pulling down the same SDK and cppwinrt version. I've added some logging to see if I can diagnose what's up. The failure is on the longest path (the one with |
|
Ah interesting; in local testing the paths on the subst'ed drive are still canonicalised back to their original drive paths -- which I suppose makes sense :) |
|
@asklar has more experience with the long path support. |
|
@cbracken Glad to hear long paths support in cppwinrt is working locally for you! In order for cppwinrt to work with long paths, you have to enable long paths system-wide: |
|
@asklar thanks! Verified the long paths registry key is set on my machine; taking a look at wiring up a command in our build recipe to flip that value on the bot, which seems like something we should be doing in 2021 regardless :) |
|
I've landed an update to the Windows engine recipe that enables long paths in https://flutter-review.googlesource.com/c/recipes/+/13300. |
|
Similar change for the web engine shards, which also need long path support since cppwinrt is run as part of gclient runhooks, which happens in all engine shards. https://flutter-review.googlesource.com/c/recipes/+/13301. Barring the web engine shard, which should be fixed by that patch, presubmits are looking good. Thanks @clarkezone @kennykerr and @asklar for your help debugging this -- and for getting the path length issue fixed before we even ran across it here! |
We now build against a specific Windows SDK rather than whatever happens to be installed on the host machine. This also rolls the buildroot to include change flutter/buildroot#448, which generates the WinRT headers from the CIPD Windows SDK. This also rolls an updated version of cppwinrt that includes supports for long paths. This also re-enables the UWP builder.
|
Woot! Thx Chris, Kenny and Alex! |
* ccaae8d Roll Skia from 537293bf155f to adadb95a9f1e (1 revision) (flutter/engine#25905) * 2e3a7f8 Roll buildroot to pick change to cppwinrt invocation (flutter/engine#25993) * 1c22286 [Linux] revise dark theme detection (flutter/engine#25535) * 7424400 Moved PlatformMessage's to unique_ptrs (flutter/engine#25860) * 406c4da Ensure that AutoIsolateShutdown drops its reference to the DartIsolate on the intended task runner (flutter/engine#25899) * 72c2fda [web] Fix incorrect physical size due to visualviewport api on iOS (flutter/engine#25895) * a712ffe Roll Dart SDK from b8f4018535fa to 86c749398b3a (16 revisions) (flutter/engine#25999) * edbbb12 Roll Fuchsia Mac SDK from uQgs5ZmFq... to aCsEHpnS0... (flutter/engine#26001) * afbbeac Implement smooth resizing for Linux (flutter/engine#25884) * 3ffb8ef Roll Dart SDK from 86c749398b3a to b4210cc43086 (2 revisions) (flutter/engine#26006) * 039dcd9 pull googletest from github instead of fuchsia.googlesource (flutter/engine#25907) * 9c793f1 Roll Skia from adadb95a9f1e to 1dc2d0fe0fa0 (98 revisions) (flutter/engine#26009) * 82efb9a Roll Skia from 1dc2d0fe0fa0 to 115645ee9b1b (2 revisions) (flutter/engine#26012) * 91a4c72 Delete unused method from engine_layer.h (flutter/engine#25924) * 619f82f fuchsia: Fix multi-views fallout (flutter/engine#25984) * 0b4bf7e Fixes BUILD.gn if is_fuchsia (legacy embedder) and is_debug (flutter/engine#25858) * 2e9de09 Streamline frame timings recording (flutter/engine#25892) * 1077da8 [vsync_waiter] add AwaitVSyncForSecondaryCallback() (flutter/engine#25787) * 0053bef [build_fuchsia_artifacts] Move license copying into BuildBucket(). (flutter/engine#25815) * e8b80e7 Roll Skia from 115645ee9b1b to c411429239e9 (7 revisions) (flutter/engine#26018) * d3353b2 Move more parts to libraries. (flutter/engine#25863) * d1a1182 Roll Dart SDK from b4210cc43086 to 04e55dad908d (2 revisions) (flutter/engine#26020) * f631f5b Exclude third_party/dart/third_party/devtools from the license script (flutter/engine#25918) * 304539b Roll Fuchsia Mac SDK from aCsEHpnS0... to OyXxehV6e... (flutter/engine#26022) * c3e28ae Roll Fuchsia Linux SDK from 4numS0K6T... to -FIIsjZj2... (flutter/engine#26023) * 6cacb53 Roll Skia from c411429239e9 to 72de83df3a03 (1 revision) (flutter/engine#26024) * bfccba5 Add dependency on Windows SDK CIPD package (flutter/engine#26003) * 06cbf1e Roll Dart SDK from 04e55dad908d to 094c9024373c (1 revision) (flutter/engine#26027) * 73aaeea Roll Skia from 72de83df3a03 to dabb2891c4a1 (4 revisions) (flutter/engine#26025) * e229649 Extract Windows string_conversion target (flutter/engine#26029) * 3d73e06 Extract FML command_line target (flutter/engine#26028) * 4aace54 Make SceneBuilder.push* not return nullable objects (flutter/engine#25991) * 0d62a56 Roll Dart SDK from 094c9024373c to 2ea89ef8f6de (1 revision) (flutter/engine#26030) * 5a26c1f Use string_view inputs for conversion functions (flutter/engine#26031) * 4f28de4 Support windows registry access (flutter/engine#26032) * 234fae1 Roll Fuchsia Linux SDK from -FIIsjZj2... to KZCe5FqMb... (flutter/engine#26034) * 7a47d3b Roll Fuchsia Mac SDK from OyXxehV6e... to DSk0IzBHv... (flutter/engine#26035) * 01f9bd8 Roll Skia from dabb2891c4a1 to 686dd910dd6c (1 revision) (flutter/engine#26036) * 1825bef Revert Dart SDK to b8f4018535fa792891e2add3a475f35e3ec156ab (flutter/engine#26037)
We now build against a specific Windows SDK rather than whatever happens to be installed on the host machine. This also rolls the buildroot to include change flutter/buildroot#448, which generates the WinRT headers from the CIPD Windows SDK. This also rolls an updated version of cppwinrt that includes supports for long paths. This also re-enables the UWP builder.
5 participants
We now build against a specific Windows SDK rather than whatever happens
to be installed on the host machine.
This also rolls the buildroot to include change
flutter/buildroot#448, which generates the WinRT
headers from the CIPD Windows SDK.
This also re-enables the UWP builder.
Fixes flutter/flutter#81994
Fixes flutter/flutter#82009
Covered by existing tests.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.