It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

We need a test for this as well

@chunhtai Any guidance on how to test this?

We could maybe test [FlutterTextInputPlugin firstRectForCharacterRange:actualRange:] in FlutterTextInputTest, one complication with it is that it self.flutterViewController.view.window convertRectToScreen: which we might need to mock.

@knopp That sounds good, let me know if you run into issue

I've added a test for this.

@chunhtai Can you review this again please? Let's unblock this ASAP.

Hi @knopp I assume this is the accent popup

I applied the change and it doesn't seem to work?

@chunhtai, it is. Do flutter_desktop_darwin_unittests pass? Which flutter version are you testing this with?

I just tested at the latest framework

commit 82cfa25a64e51c5e25159284f8450deb72e7b73b (HEAD -> master, upstream/master)
Author: Jonah Williams <[email protected]>
Date:   Thu Apr 22 13:35:45 2021 -0700

    [flutter_tools] fix asset directory paths for UWP (#80984)

and applied local changes to the my engine build

I am using multiple screen and the flutter app is not on my primary screen i think. I ran into similar issue when I convert rect for accessibility I wonder if you need to do the same?

@chunhtai, I tested this with multiple displays. [window convertRectToScreen] should take care of that. I just noticed that there is one oversight in the code - It assumes that view covers entire window. Which is currently true but might not be in future, the rect should be converted from view to window coordinates first. But this shouldn't cause the problem you're seeing.

I've pushed fix for the view->window conversion. My framework / engine are couple of days older than yours, I'll update and retest this.

@chunhtai, anything else needed here?