This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fixes reference retaining issue in flutter text input plugin #24768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Hi @gaaclarke I manage to write a mrc test to test the retaining count. I feel the test is quite fragile, but this is the only thing i can come up with. Can you take a look at this PR? |
gaaclarke
reviewed
Mar 12, 2021
Member
There was a problem hiding this comment.
The fix looks good. I think the easiest way to test this would be to make an ARC test, then get a weak pointer to _activeView and assert that it does or does not get nil'd out to zero. Remember in ARC it will automatically set weak references to nil.
Something like this:
FlutterTextInputPlugin* plugin = [[FlutterTextInputPlugin alloc] init];
__weak UIView* activeView;
__weak UIView* oldActiveView;
@autoreleasepool {
UIView* newActiveView = [[UIView alloc] init];
activeView = newActiveView;
oldActiveView = plugin.activeView;
[plugin doSomethingThatReplacesTheActiveView:newActiveView];
}
// This assert proves that the plugin retained the newActiveView.
XCTAssertNotNil(activeView);
// This assert proves we released the old active view.
XCTAssertNil(oldActiveView);
Contributor
Author
|
@gaaclarke ahhhh nice! thanks for the suggestion, it does capture the failure prior to this change. this is ready for review |
gaaclarke
approved these changes
Mar 12, 2021
| }]; | ||
| XCTAssertNotNil(activeView); | ||
| } | ||
| // This assert proves the myInputPlugin.textInputView is not gc'd. |
chunhtai
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 16, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 16, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 16, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 16, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 16, 2021
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 16, 2021
* b2d02f7 Roll Fuchsia Linux SDK from GsRYVri0-... to aRqEDMjwC... (flutter/engine#24990) * 3a1a3e6 Roll Skia from 7854da39b3c1 to 4fb13e026b6b (20 revisions) (flutter/engine#24993) * e3a84f9 Fixed issue where the gpu disable syncswitch was being overridden after init. (flutter/engine#24958) * aa83691 fix selectable text selections are not announced in voice over (flutter/engine#24933) * 04b0451 fixes reference retaining issue in flutter text input plugin (flutter/engine#24768) * 1ea7dc6 Set automatic simulator rotation in scenario test (flutter/engine#24985) * 38977a5 Implement AXPlatformNodeBase::GetInstanceCountForTesting (flutter/engine#24999) * a25b0de Roll Fuchsia Mac SDK from xOxFrRRO6... to pmsuWkRQA... (flutter/engine#24997) * 3270c87 Roll Skia from 4fb13e026b6b to 1aa25c3217b6 (25 revisions) (flutter/engine#25001) * 96d5104 [deferred components] Handle base module loading units (flutter/engine#24983) * 6a3d8c7 Roll Skia from 1aa25c3217b6 to ead52dc068d5 (1 revision) (flutter/engine#25005) * 0f52360 Hardware Keyboard: macOS (flutter/engine#23469)
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
chriscraws
pushed a commit
to chriscraws/engine
that referenced
this pull request
Mar 23, 2021
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inputview is created without anyone retaining, it work prior to this pr because the inputview was never detached from the flutterview, so the flutter view retains one reference.
My previous commit b3a18f5 detaches the inputview when user hides it, this makes it to be gc'd. This causes _activeView hold an invalid pointer.
fixes flutter/flutter#77139
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.