This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Display Features support (Foldable and Cutout) #24756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2021
Member
|
@GaryQian can you give it a look? |
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
GaryQian
reviewed
Mar 23, 2021
|
@chinmaygarde could you take another look when you get a chance? |
Member
|
I think this looks fine after Gary's review. There is a conflict but we should land this once this is resolved. |
# Conflicts: # shell/platform/android/test/io/flutter/embedding/engine/renderer/FlutterRendererTest.java
Contributor
Author
Resolved the conflict. |
chinmaygarde
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
Contributor
Author
|
|
Contributor
Author
|
Triggered another ci run |
Contributor
Author
|
@chinmaygarde The tree is green and this can land now, the tag you added was removed automatically due to a flaky build. |
GaryQian
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 3, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 3, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 3, 2021
zanderso
added a commit
that referenced
this pull request
Sep 3, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 3, 2021
Contributor
|
FYI @andreidiaconu Looks like this was reverted due to failures rolling this into flutter framework: flutter/flutter#89430 (comment) Revert is: #28447 |
Contributor
Author
This was referenced Sep 5, 2021
This was referenced Nov 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for foldable devices and display cutouts, in the form of Display Features.
A display feature is an area of the display that is obstructed by a hardware feature. For now, this works only on Android. There are three types of display features:
Here is a preview of what this PR enables, on a dual-screen emulator:
Issues that will be closed by this PR:
Work in progress: