Windows UWP: Add support for emulated mouse cursor for targets such as XBOX #24698
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
First round of comments attached. Excited to see Flutter working with game pads!
|
@clarkezone Any updates on @cbracken review comments? |
|
Appols, I was waiting for some of the other UWP commits to land which they now have, was looking at the template in the meantime. I'll take a look this weekend, likely tomorrow. |
|
@cbracken Your comments seems to have been addressed (not sure if completely so). Can you re-review please so we can unblock? |
|
I haven't been through them all yet, I plan on finishing up the review by the end of the weekend. |
clarkezone
force-pushed
the
add-xbox-mouseemulation
branch
3 times, most recently
from
8558c92 to
b9c48fb
Compare
|
OK I'm done with changes.. |
clarkezone
force-pushed
the
add-xbox-mouseemulation
branch
from
b9c48fb to
625a0eb
Compare
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
lgtm on pass two! Thanks for the fixes!
…ads on devices which do not have a physical mouse.
cbracken
force-pushed
the
add-xbox-mouseemulation
branch
from
cc8a24b to
b936e39
Compare
|
Rebased against tip-of-tree after the software-rendering fallback landed. |
…s XBOX (flutter#24698) Adds an emulated mouse cursor for devices that don't typically have a traditional mouse. Enables mouse-like user interactions by using gamepad devices. flutter/flutter#76092 flutter/flutter#14967 Unit tests blocked by: flutter/flutter#70197 label added
4 participants
Adds an emulated mouse cursor for devices that don't typically have a traditional mouse. Enables mouse-like user interactions by using gamepad devices.
flutter/flutter#76092
flutter/flutter#14967
Unit tests blocked by: flutter/flutter#70197 label added
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.