Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll buildroot to 33f05b6c #23986

Merged
stuartmorgan-g merged 1 commit into from
Jan 28, 2021
Merged

Roll buildroot to 33f05b6c #23986

stuartmorgan-g merged 1 commit into from
Jan 28, 2021

Conversation

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Jan 27, 2021

Picks up flutter/buildroot#431

Fixes flutter/flutter#66575 and flutter/flutter#74599.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

@google-cla google-cla bot added the cla: yes label Jan 27, 2021
@stuartmorgan-g stuartmorgan-g merged commit 353efcd into master Jan 28, 2021
@stuartmorgan-g stuartmorgan-g deleted the libcxx-visibility-roll branch January 28, 2021 00:16
zanderso added a commit that referenced this pull request Jan 28, 2021
@zanderso
Revert "Roll buildroot to 33f05b6 (#23986)"
0b9a3e9 
This reverts commit 353efcd.
@zanderso zanderso mentioned this pull request Jan 28, 2021
Merged
zanderso added a commit that referenced this pull request Jan 28, 2021
@zanderso
Revert "Roll buildroot to 33f05b6 (#23986)" (#24009)
c4d1058 
This reverts commit 353efcd.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 28, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 28, 2021
@engine-flutter-autoroll
353efcd Roll buildroot to 33f05b6 (flutter/engine#23986)
d81c353
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 28, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 28, 2021
@engine-flutter-autoroll
353efcd Roll buildroot to 33f05b6 (flutter/engine#23986)
1489b0e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 28, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 28, 2021
@engine-flutter-autoroll
353efcd Roll buildroot to 33f05b6 (flutter/engine#23986)
a1db7b6
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@stuartmorgan-g @hjfreyer
Roll buildroot to 33f05b6 (flutter#23986)
bc17676 
Picks up flutter/buildroot#431
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@zanderso @hjfreyer
Revert "Roll buildroot to 33f05b6 (flutter#23986)" (flutter#24009)
6528660 
This reverts commit 353efcd.
@cbracken cbracken mentioned this pull request May 13, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@cbracken cbracken cbracken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong Flutter behavior with plugins that throw and catch C++ exceptions

3 participants

@stuartmorgan-g @chinmaygarde @cbracken