This repository was archived by the owner on Feb 25, 2025. It is now read-only.
add ffi_allocation_patch.dart to libraries.yaml #23808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 20, 2021
Revert submission 177862 Reason for revert: breaks g3 without flutter/engine#23808 Reverted Changes: I50b3b4c31:[vm/ffi] Roll `package:ffi` to `Allocator` and `Op... I3f5b08c08:[vm/ffi] Change `Pointer<T extends Struct>.ref` to... I6141c193b:[vm/ffi] Disallow empty structs Change-Id: I1bfe4d70a5f7f35039b8a01d599d33542872574c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180183 Reviewed-by: Daco Harkes <[email protected]>
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 20, 2021
Revert submission 177862 Reason for revert: breaks g3 without flutter/engine#23808 Reverted Changes: I50b3b4c31:[vm/ffi] Roll `package:ffi` to `Allocator` and `Op... I3f5b08c08:[vm/ffi] Change `Pointer<T extends Struct>.ref` to... I6141c193b:[vm/ffi] Disallow empty structs Change-Id: Ibe9e8200dbdafe0ee684a6a0ea19e06214edf5e0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180184 Reviewed-by: Daco Harkes <[email protected]>
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 20, 2021
Revert submission 177862 Reason for revert: breaks g3 without flutter/engine#23808 Reverted Changes: I50b3b4c31:[vm/ffi] Roll `package:ffi` to `Allocator` and `Op... I3f5b08c08:[vm/ffi] Change `Pointer<T extends Struct>.ref` to... I6141c193b:[vm/ffi] Disallow empty structs Change-Id: I128e7b096faea650e0ba0850a411eed3e97c00e6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180185 Reviewed-by: Daco Harkes <[email protected]>
zanderso
reviewed
Jan 20, 2021
| uri: "../../../../../../third_party/dart/sdk/lib/ffi/ffi.dart" | ||
| patches: | ||
| - "../../../../../../third_party/dart/sdk/lib/_internal/vm/lib/ffi_patch.dart" | ||
| - "../../../../../../third_party/dart/sdk/lib/_internal/vm/lib/ffi_allocation_patch.dart" |
Contributor
|
Can I fix the nit in a new PR and let this merge ? |
a-siva
approved these changes
Jan 21, 2021
Member
|
Yes |
zanderso
added
the
waiting for tree to go green
Contributor
|
Turns out the style is matching the way the patch files are listed in that file, the first entry is the patch of main library file and the rest are sorted alphabetically. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 21, 2021
renyou
pushed a commit
to renyou/engine
that referenced
this pull request
Jan 21, 2021
renyou
added a commit
that referenced
this pull request
Jan 21, 2021
Co-authored-by: Daco Harkes <[email protected]>
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the missing patch file for ffi. This matches what is in https://github.com/dart-lang/sdk/blob/master/sdk/lib/libraries.yaml.
Prior art PR: #23000