Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Jan 11, 2021

Description

Implemented sharing font collections between spawned engines.

Related Issues

fixes flutter/flutter#72024

Tests

I added the following tests:

EngineTest unit tests.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@gaaclarke gaaclarke changed the title Lfe share fonts share font collections between spawn engines Jan 11, 2021
@gaaclarke gaaclarke force-pushed the lfe-share-fonts branch 3 times, most recently from 4987393 to 388c0a8 Compare January 13, 2021 01:35
@gaaclarke gaaclarke marked this pull request as ready for review January 13, 2021 01:37
@gaaclarke
Copy link
Member Author

Landing on red, the red is an infra failure timeout.

@gaaclarke gaaclarke merged commit 07689c2 into flutter:master Jan 13, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 13, 2021
gspencergoog pushed a commit to gspencergoog/engine that referenced this pull request Jan 20, 2021
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share font collections between multiple engines

4 participants