This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Rename DynamicFeature->DeferredComponent and impl uninstall DeferredComponents #23224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
GaryQian
changed the title
GaryQian
changed the title
GaryQian
force-pushed
the
splitaotuninstall
branch
from
b70b2d1 to
efa22a4
Compare
GaryQian
changed the title
18 tasks
xster
approved these changes
Jan 7, 2021
| * uninstall. Actual uninstallation (eg, removal of assets and files) may occur at a later time. | ||
| * However, once uninstallation is requested, the dynamic feature should not be used anymore until | ||
| * {@link installDynamicFeature} is called again. | ||
| * |
Member
There was a problem hiding this comment.
describe what does it do specifically? Does it remove files on disk?
| "Dynamic feature module name was null and could not be resolved from loading unit id."); | ||
| return; | ||
| } | ||
| List<String> modules_to_uninstall = new ArrayList<>(); |
| dynamicFeatureManager.getDynamicFeatureInstallState(loadingUnitId, moduleName)); | ||
| break; | ||
| case "uninstallDynamicFeature": | ||
| dynamicFeatureManager.uninstallDynamicFeature(loadingUnitId, moduleName); |
Member
There was a problem hiding this comment.
shouldn't the couldn't find unit signal feedback into the result?
GaryQian
force-pushed
the
splitaotuninstall
branch
2 times, most recently
from
c96d358 to
a564dcc
Compare
GaryQian
changed the title
GaryQian
changed the title
GaryQian
added
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
GaryQian
force-pushed
the
splitaotuninstall
branch
from
0866938 to
bf0f880
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2021
…eferredComponents (flutter/engine#23224)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2021
…eferredComponents (flutter/engine#23224)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2021
…eferredComponents (flutter/engine#23224)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2021
…eferredComponents (flutter/engine#23224)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2021
…eferredComponents (flutter/engine#23224)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2021
…eferredComponents (flutter/engine#23224)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2021
…eferredComponents (flutter/engine#23224)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames Dynamic Features to DeferredComponents (as per discussion in go/flutter-dynamic-features-tooling)
Adds uninstalling deferred components.
Resolves flutter/flutter#72757