TextFormField does not get blurred when tapped outside of the widget. #22517

stevenmetzger · 2020-11-14T02:59:32Z

Description

This PR addresses flutter/flutter#64245
TextFormField does not get blurred when tapped outside of the widget.

Previously, Flutter for Web behaved like a web page. If user clicked on an
area other than the input field itself, the input field was blurred, thus
the connection is closed.
This behavior was changed for Desktop Browsers.
[web] Remove connection close on blur for desktop browsers #18743

Now only, pressing enter or tab changes the focus of the input fields.

This created a regression for applications that relied on the old behavior
[web] TextFormField does not get blurred when tapped outside of the widget. flutter#64245
This change adds a flag which will provides a workaround to the
regression allowing developers to optionally force the connection
to close on blur, as suggested in the comments
[web] TextFormField does not get blurred when tapped outside of the widget. flutter#64245 (comment)

Related Issues

#18743
flutter/flutter#64245
flutter/flutter#64245 (comment)

Tests

I added the following tests:

A second test that verifies the same behaviour that existed prior to the regression in the case where the optional argument to use that old behaviour is included.
Because I didn't change the default behaviour I left the original test unchanged.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the contributor guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the C++, Objective-C, Java style guides for the engine.
I read the tree hygiene wiki page, which explains my responsibilities.
I updated/added relevant documentation.
All existing and new tests are passing.
I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

I have submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.

googlebot · 2020-11-14T02:59:36Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-11-14T02:59:36Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

stevenmetzger · 2020-11-14T03:14:21Z

@googlebot I fixed it.

googlebot · 2020-11-14T03:14:26Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

google-cla · 2020-11-14T03:14:26Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

chinmaygarde · 2020-11-19T22:47:02Z

cc @yjbanov

mdebbar

Thanks for the contribution @stevenmetzger! Overall, this PR looks good.

I'm assuming there'll be a PR for the framework side too? If you can create a framework PR, that would be great so we can review (and submit) them both together.

mdebbar · 2021-01-19T21:57:44Z

lib/web_ui/lib/src/engine/text_editing/text_editing.dart

+      if (domElementIsActive && _inputConfiguration.forceCloseConnectionOnBlur) {
+        owner.sendTextConnectionClosedToFrameworkIfAny();
+      } else {
+        domElement.focus();


This code has changed in 2948fee#diff-bd1a19d2674a1ef5a2a2541853d7c2d815acbdd2255b1edf6611486b52811dbe. Could you please rebase?

Thanks for the feedback @mdebbar. Yes, I have created a PR for the framework side too. flutter/flutter#74354. Sorry I didn't include this in the first place, I wasn't sure what the best practice was for changes that touch multiple projects.

I have rebased the change.

* Add optional argument (forceCloseConnectionOnBlur) to TextField * This PR is meant to accompany this change to flutter/engine flutter/engine#22517

* Add optional argument (forceSubmitOnFocusLost) to TextField * This PR is meant to accompany this change to flutter/engine flutter/engine#22517

Hixie · 2021-10-19T23:11:42Z

@mdebbar is this on your radar?

mdebbar · 2021-10-20T14:27:47Z

The framework companion of this PR was closed due to inactivity. I'm closing this one too.

@stevenmetzger feel free to re-open and update the PRs.

googlebot added the cla: no label Nov 14, 2020

googlebot removed the cla: no label Nov 14, 2020

google-cla bot added the cla: yes label Nov 14, 2020

chinmaygarde added the platform-web Code specifically for the web engine label Nov 19, 2020

yjbanov requested a review from mdebbar January 14, 2021 23:44

mdebbar reviewed Jan 19, 2021

View reviewed changes

TextFormField does not get blurred when tapped outside of the widget.

cd334c4

stevenmetzger force-pushed the master branch from 08e7942 to cd334c4 Compare January 20, 2021 20:33

stevenmetzger mentioned this pull request Jan 20, 2021

TextFormField does not get blurred when tapped outside of the widget. flutter/flutter#74354

Closed

8 tasks

change forceCloseConnectionOnBlur to forceSubmitOnFocusLost

ee289f3

mdebbar closed this Oct 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

TextFormField does not get blurred when tapped outside of the widget. #22517

TextFormField does not get blurred when tapped outside of the widget. #22517

Uh oh!

stevenmetzger commented Nov 14, 2020

Uh oh!

googlebot commented Nov 14, 2020

Uh oh!

google-cla bot commented Nov 14, 2020

Uh oh!

stevenmetzger commented Nov 14, 2020

Uh oh!

googlebot commented Nov 14, 2020

Uh oh!

google-cla bot commented Nov 14, 2020

Uh oh!

chinmaygarde commented Nov 19, 2020

Uh oh!

mdebbar left a comment

Uh oh!

mdebbar Jan 19, 2021

Uh oh!

stevenmetzger Jan 20, 2021

Uh oh!

Hixie commented Oct 19, 2021

Uh oh!

mdebbar commented Oct 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TextFormField does not get blurred when tapped outside of the widget. #22517

TextFormField does not get blurred when tapped outside of the widget. #22517

Uh oh!

Conversation

stevenmetzger commented Nov 14, 2020

Description

Related Issues

Tests

Checklist

Reviewer Checklist

Breaking Change

Uh oh!

googlebot commented Nov 14, 2020

Uh oh!

google-cla bot commented Nov 14, 2020

Uh oh!

stevenmetzger commented Nov 14, 2020

Uh oh!

googlebot commented Nov 14, 2020

Uh oh!

google-cla bot commented Nov 14, 2020

Uh oh!

chinmaygarde commented Nov 19, 2020

Uh oh!

mdebbar left a comment

Choose a reason for hiding this comment

Uh oh!

mdebbar Jan 19, 2021

Choose a reason for hiding this comment

Uh oh!

stevenmetzger Jan 20, 2021

Choose a reason for hiding this comment

Uh oh!

Hixie commented Oct 19, 2021

Uh oh!

mdebbar commented Oct 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants