Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland "remove surface dependance on external view embedder (#22468)" #22470

Merged
iskakaushik merged 2 commits into from
Nov 12, 2020
Merged

Reland "remove surface dependance on external view embedder (#22468)" #22470

iskakaushik merged 2 commits into from
Nov 12, 2020

Conversation

@iskakaushik
Copy link
Contributor

@iskakaushik iskakaushik commented Nov 12, 2020

Also adds a test for the failure seen in flutter/flutter#70384

This reverts commit 021ff04.

@iskakaushik
Reland "remove surface dependance on external view embedder (flutter#…
5f35e02 
…22468)"

This reverts commit 021ff04.

Also adds a test for the failure
@google-cla google-cla bot added the cla: yes label Nov 12, 2020
@iskakaushik iskakaushik force-pushed the reland-remove-ext-view branch from 2505a04 to a1e9fe2 Compare November 12, 2020 17:51
@liyuqian
Copy link
Contributor

liyuqian commented Nov 12, 2020 •
edited
Loading

Another test is failing:

[ RUN      ] ShellTest.ExternalEmbedderNoThreadMerger
[FATAL:flutter/testing/test_timeout_listener.cc(45)] Check failed: delay < timeout_. Test ShellTest.ExternalEmbedderNoThreadMerger did not complete in 30 seconds and is assumed to be hung. Killing the test harness.

@iskakaushik iskakaushik force-pushed the reland-remove-ext-view branch from a1e9fe2 to 71727f1 Compare November 12, 2020 19:07
@iskakaushik iskakaushik force-pushed the reland-remove-ext-view branch from 71727f1 to b3caf92 Compare November 12, 2020 19:43
@iskakaushik
Copy link
Contributor Author

iskakaushik commented Nov 12, 2020

@jason-simmons looks like raster_thread_merger_ can be null when we call EndFrame, iOS implementation just clears the composition order, and on Android when surface is set, raster_thread_merger_ is always set. So just checking for surface is the right call here I think.

@iskakaushik iskakaushik added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 12, 2020
liyuqian
liyuqian approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Nov 12, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Web Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 12, 2020
@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 12, 2020
@chinmaygarde
Copy link
Member

chinmaygarde commented Nov 12, 2020

I've filed a flake report and re-run the presubmit.

@iskakaushik iskakaushik merged commit 1ff237f into flutter:master Nov 12, 2020
@iskakaushik iskakaushik deleted the reland-remove-ext-view branch November 12, 2020 23:37
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2020
@engine-flutter-autoroll
1ff237f Reland "remove surface dependance on external view embedder (f…
a13a5ac 
…lutter#22468)" (flutter/engine#22470)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2020
@engine-flutter-autoroll
1ff237f Reland "remove surface dependance on external view embedder (f…
9c4ccdd 
…lutter#22468)" (flutter/engine#22470)
@gaaclarke gaaclarke mentioned this pull request Nov 13, 2020
Closed
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
@iskakaushik @chaselatta
Reland "remove surface dependance on external view embedder (flutter#…
4c36452 
…22468)" (flutter#22470)
@chinmaygarde chinmaygarde mentioned this pull request Dec 14, 2020
Closed
@dkwingsmt dkwingsmt mentioned this pull request Feb 23, 2023
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

@liyuqian liyuqian liyuqian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-android platform-ios waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iskakaushik @liyuqian @fluttergithubbot @chinmaygarde @jason-simmons