This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Default to 2.7 when generating the package config #22469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
approved these changes
Nov 12, 2020
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
Is there any practical difference between 2.8 and 2.7?
Member
Author
That's a good question for @leafpetersen and @mit-mit =) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2020
Not that I'm aware of. We introduced language versioning in 2.7, I believe, which is why we chose that as the base language version. But we didn't add any language features in 2.8. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2020
pcsosinski
pushed a commit
to pcsosinski/engine
that referenced
this pull request
Nov 13, 2020
pcsosinski
pushed a commit
that referenced
this pull request
Nov 13, 2020
* Update 1.24 engine to use Dart 2.12.0-29.7.beta * Default to 2.7 when generating the package config (#22469) For flutter/flutter#70349 * Disable synchronous resizing until a frame is produced (#22457) Instead of synchronousResizing flag which in some cases seems to be set too early, synchronous resizing is postponed until framework produces a frame so ResizeSynchronizer knows for sure that the engine is up and running. * update license file for Dart 2.12.0-29.7.beta Co-authored-by: Zachary Anderson <[email protected]> Co-authored-by: Matej Knopp <[email protected]>
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For flutter/flutter#70349