Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Nov 5, 2020

Description

This reverts commit 7a8057b because it breaks back button functionality.

Related Issues

Fixes flutter/flutter#69886

…nputConnection.sendKeyEvent on Android (flutter#22304)"

This reverts commit 7a8057b because it breaks back button functionality.
@gspencergoog gspencergoog merged commit 5d481fb into flutter:master Nov 5, 2020
@gspencergoog gspencergoog deleted the revert_pre_ime branch November 5, 2020 17:02
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2020
gspencergoog added a commit to gspencergoog/engine that referenced this pull request Nov 6, 2020
…ent to InputConnection.sendKeyEvent on Android (flutter#22304)" (flutter#22321)"

This reverts commit 5d481fb.
gspencergoog added a commit that referenced this pull request Nov 6, 2020
…Event on Android (#22340)

This (mostly) re-lands #21163, which was reverted in #22321

This switches from using onKeyDown to using dispatchKeyEvent on Android so that keys can be intercepted handled by the framework and not continue to be dispatched to other controls.

It also now intercepts key events sent to InputConnection.sendKeyEvent, as some IMEs do (e.g. the Hacker's Keyboard), and sends them to Flutter.

This fixes the problem where (for example) pressing TAB on a hardware keyboard sends the tab to both the text field and to the focus traversal system.

Note that we still can't intercept all keystrokes given to a soft keyboard, only those which the soft keyboard decides to send to InputConnection.sendKeyEvent, and system keys (like the back button) are only received if the IME doesn't eat them.
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
…nputConnection.sendKeyEvent on Android (flutter#22304)" (flutter#22321)

This reverts commit 7a8057b because it breaks back button functionality.
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
…Event on Android (flutter#22340)

This (mostly) re-lands flutter#21163, which was reverted in flutter#22321

This switches from using onKeyDown to using dispatchKeyEvent on Android so that keys can be intercepted handled by the framework and not continue to be dispatched to other controls.

It also now intercepts key events sent to InputConnection.sendKeyEvent, as some IMEs do (e.g. the Hacker's Keyboard), and sends them to Flutter.

This fixes the problem where (for example) pressing TAB on a hardware keyboard sends the tab to both the text field and to the focus traversal system.

Note that we still can't intercept all keystrokes given to a soft keyboard, only those which the soft keyboard decides to send to InputConnection.sendKeyEvent, and system keys (like the back button) are only received if the IME doesn't eat them.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken keyboard hide logic on back button click

2 participants