Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Deprecate Android v1 embedding classes" #21338

Merged
zanderso merged 1 commit into from
Sep 22, 2020
Merged

Revert "Deprecate Android v1 embedding classes" #21338

zanderso merged 1 commit into from
Sep 22, 2020

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Sep 22, 2020

Reverts #20868

@zanderso zanderso requested a review from xster September 22, 2020 21:29
@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 22, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@zanderso zanderso mentioned this pull request Sep 22, 2020
Closed
@zanderso
Copy link
Member Author

zanderso commented Sep 22, 2020

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8868427309973228272/+/steps/run_test.dart_for_tool_tests_shard_and_subshard_integration/0/stdout?format=raw

dnfield
dnfield approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield mentioned this pull request Sep 22, 2020
Closed
@zanderso zanderso merged commit c62d665 into master Sep 22, 2020
@zanderso zanderso deleted the revert-20868-deprecate-v1 branch September 22, 2020 21:38
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 22, 2020
@engine-flutter-autoroll
c62d665 Revert "Deprecate Android v1 embedding classes (flutter#20868)…
98e4fee 
…" (flutter/engine#21338)
@xster xster mentioned this pull request Sep 23, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xster xster Awaiting requested review from xster

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zanderso @dnfield @googlebot