This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add a new raster status kSkipAndRetry frame
#21059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
reviewed
Sep 9, 2020
blasten
force-pushed
the
cleanup_rasterizer
branch
from
d6ba120 to
9beece6
Compare
blasten
force-pushed
the
cleanup_rasterizer
branch
from
9beece6 to
e23b573
Compare
blasten
force-pushed
the
cleanup_rasterizer
branch
from
e23b573 to
f33efcb
Compare
blasten
changed the title
kSkipAndRetry frame
iskakaushik
reviewed
Sep 11, 2020
flow/compositor_context.h
Outdated
| kSuccess, | ||
| // Frame needs to be resubmitted for rasterization. This is | ||
| // currently only called when thread configuration change occurs. | ||
| // Frame is submitted twice. This is currently only used when |
Contributor
There was a problem hiding this comment.
What does frame with the same layer tree mean and how is it different from the same frame being submitted twice? It might be worth clarifying the difference here.
blasten
added
the
waiting for tree to go green
fluttergithubbot
removed
the
waiting for tree to go green
blasten
force-pushed
the
cleanup_rasterizer
branch
from
64a439e to
1e7b26e
Compare
blasten
force-pushed
the
cleanup_rasterizer
branch
from
1e7b26e to
2e121b6
Compare
blasten
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2020
pcsosinski
pushed a commit
to pcsosinski/engine
that referenced
this pull request
Sep 15, 2020
pcsosinski
pushed a commit
that referenced
this pull request
Sep 15, 2020
* Update 1.22 engine to use Dart 2.10.0-110.3.beta * Add a new raster status `kSkipAndRetry` frame (#21059) * update license file for Dart 2.10.0-110.3.beta * Account for current open image in FlutterImageView (#21191) Co-authored-by: Emmanuel Garcia <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As it turns out, the Android external view embedder had infrastructure built to work around the fact that the rasterizer submits a frame that should be resubmitted. We can simplify the current implementation by just skipping these frames.
This also fixes flutter/flutter#65404
Related Issues
flutter/flutter#65404
Tests
I added the following tests: Unit tests
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.