Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Manual roll of Dart b29f228f62...016e8880f0 #20967

Merged
a-siva merged 1 commit into from
Sep 4, 2020
Merged

Manual roll of Dart b29f228f62...016e8880f0 #20967

a-siva merged 1 commit into from
Sep 4, 2020

Conversation

@a-siva
Copy link
Contributor

@a-siva a-siva commented Sep 3, 2020

Manual roll of Dart b29f228...016e888

dart-lang/sdk@016e8880f0a Version 2.10.0-90.0.dev
dart-lang/sdk@34f636ce1d8 Revert "[vm/io] Fix FileSystemWatcher enum name typo."
dart-lang/sdk@7a02118a410 [vm/fuchsia]: Safely shutdown the async message loop.
dart-lang/sdk@334d3681467 [analyzer_plugin] Remove unused dart:async imports
dart-lang/sdk@047c0f860a5 [Analyzer] Support analyzing open files without open workspaces
dart-lang/sdk@f846d0e7ea0 [analyzer_cli] Remove unused dart:async imports
dart-lang/sdk@ba372d6e8a4 [dartdev] Remove unused dart:async import
dart-lang/sdk@30cfb228c00 [nnbd_migration] Remove unused dart:async imports
dart-lang/sdk@1134a0f17c8 [analysis_server] Remove unused dart:async imports
dart-lang/sdk@3317d47c7de [_fe_analyzer_shared] Remove unused dart:async import
dart-lang/sdk@0a036db5962 [vm/io] Fix FileSystemWatcher enum name typo.
dart-lang/sdk@000f3135a5c [analyzer] Remove unused dart:async imports
dart-lang/sdk@7817aa17967 [dartfix] Remove unused dart:async imports
dart-lang/sdk@0144087619f Version 2.10.0-89.0.dev
dart-lang/sdk@42dfb9d3046 Add generateCallGraphWithDominators method to generate a CallGraph from a precompiler trace.
dart-lang/sdk@01024dfa5a8 Issue 43200. Report ASSIGNMENT_TO_FINAL when 'final late' has an initializer.
dart-lang/sdk@ab16d79af97 Revert "Flow analysis changes to fix mixed-mode unsoundness loophole."
dart-lang/sdk@7363adca67a [infra] Update checked-in SDKs to 2.10.0-79.0.dev
dart-lang/sdk@d833f2f65c1 Flow analysis changes to fix mixed-mode unsoundness loophole.
dart-lang/sdk@33e4a6bc2a8 Revert "[vm] Have Read/WriteStream use (S)LEB128 for variable-length encoding."
dart-lang/sdk@d9dc24b53e7 Version 2.10.0-88.0.dev
dart-lang/sdk@7130dd4d3d9 [cfe] Report error on non-void setter return type
dart-lang/sdk@a7cb764aa45 [tests/ffi] Reinstate deleted test
dart-lang/sdk@39689eb07cd [co19] Roll co19 to 9c07e26d67665de7972ba6f7e87369933a978545
dart-lang/sdk@1f92293fd58 Revert "[dart:html] Add 'creates' type description to JS calls"
dart-lang/sdk@e44cf969c64 Fix creates value for getStats
dart-lang/sdk@15201ebe5f1 Version 2.10.0-87.0.dev
dart-lang/sdk@eb8dfee1074 [CFE] Clean up duplicate entries in spell checker lists

@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 3, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@a-siva a-siva requested review from aam and yjbanov September 3, 2020 04:51
@aam
Copy link
Member

aam commented Sep 3, 2020

I believe compositing_test needs to be fixed since it is missing elevation required parameter(marked required in #18933):

      return builder.pushPhysicalShape(path: Path(), color: const Color.fromARGB(0, 0, 0, 0), oldLayer: oldLayer as PhysicalShapeEngineLayer);

https://github.com/flutter/engine/blob/master/lib/ui/compositing.dart#L560

  PhysicalShapeEngineLayer? pushPhysicalShape({
    required Path path,
    required double elevation,
    required Color color,
    Color? shadowColor,
    Clip clipBehavior = Clip.none,
    PhysicalShapeEngineLayer? oldLayer,
  }) {

I imagine some change in rolled dart sdk analyzer implemented this check now, that is why it only got flagged now.

@a-siva
Manual roll of Dart b29f228...016e888
1703ff4 
dart-lang/sdk@016e8880f0a Version 2.10.0-90.0.dev
dart-lang/sdk@34f636ce1d8 Revert "[vm/io] Fix FileSystemWatcher enum name typo."
dart-lang/sdk@7a02118a410 [vm/fuchsia]: Safely shutdown the async message loop.
dart-lang/sdk@334d3681467 [analyzer_plugin] Remove unused dart:async imports
dart-lang/sdk@047c0f860a5 [Analyzer] Support analyzing open files without open workspaces
dart-lang/sdk@f846d0e7ea0 [analyzer_cli] Remove unused dart:async imports
dart-lang/sdk@ba372d6e8a4 [dartdev] Remove unused dart:async import
dart-lang/sdk@30cfb228c00 [nnbd_migration] Remove unused dart:async imports
dart-lang/sdk@1134a0f17c8 [analysis_server] Remove unused dart:async imports
dart-lang/sdk@3317d47c7de [_fe_analyzer_shared] Remove unused dart:async import
dart-lang/sdk@0a036db5962 [vm/io] Fix FileSystemWatcher enum name typo.
dart-lang/sdk@000f3135a5c [analyzer] Remove unused dart:async imports
dart-lang/sdk@7817aa17967 [dartfix] Remove unused dart:async imports
dart-lang/sdk@0144087619f Version 2.10.0-89.0.dev
dart-lang/sdk@42dfb9d3046 Add `generateCallGraphWithDominators` method to generate a `CallGraph` from a precompiler trace.
dart-lang/sdk@01024dfa5a8 Issue 43200. Report ASSIGNMENT_TO_FINAL when 'final late' has an initializer.
dart-lang/sdk@ab16d79af97 Revert "Flow analysis changes to fix mixed-mode unsoundness loophole."
dart-lang/sdk@7363adca67a [infra] Update checked-in SDKs to 2.10.0-79.0.dev
dart-lang/sdk@d833f2f65c1 Flow analysis changes to fix mixed-mode unsoundness loophole.
dart-lang/sdk@33e4a6bc2a8 Revert "[vm] Have Read/WriteStream use (S)LEB128 for variable-length encoding."
dart-lang/sdk@d9dc24b53e7 Version 2.10.0-88.0.dev
dart-lang/sdk@7130dd4d3d9 [cfe] Report error on non-void setter return type
dart-lang/sdk@a7cb764aa45 [tests/ffi] Reinstate deleted test
dart-lang/sdk@39689eb07cd [co19] Roll co19 to 9c07e26d67665de7972ba6f7e87369933a978545
dart-lang/sdk@1f92293fd58 Revert "[dart:html] Add 'creates' type description to JS calls"
dart-lang/sdk@e44cf969c64 Fix creates value for getStats
dart-lang/sdk@15201ebe5f1 Version 2.10.0-87.0.dev
dart-lang/sdk@eb8dfee1074 [CFE] Clean up duplicate entries in spell checker lists
@a-siva
Copy link
Contributor Author

a-siva commented Sep 4, 2020

Landing this PR (the bot redness appears to be a flaky test). Dart rolls have been backed up by 2 days and wanted to get it back before the branch cut next week.

@a-siva a-siva merged commit d77dd31 into flutter:master Sep 4, 2020
@a-siva a-siva deleted the dartroll branch September 4, 2020 03:56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 5, 2020
@engine-flutter-autoroll
d77dd31 Manual roll of Dart b29f228f62...016e8880f0 (flutter/engine#2…
64c53cd 
…0967)
flar pushed a commit to flutter/flutter that referenced this pull request Sep 8, 2020
@engine-flutter-autoroll
Roll Engine from ac8b9c4 to d1d848e (15 revisions) (#65275)
31e5db7 
* 30b829e Populates fuchsia node actions in semantics updates. (flutter/engine#20451)

* c2e7010 Roll Skia from 1ee21cdfb6fe to 6763a713f957 (1 revision) (flutter/engine#20982)

* 841401d restore FML_DCHECK removed due to a code reviewing error (flutter/engine#20953)

* 367c6db Don't use GetTaskQueueId() in rasterizer as it breaks Fuchsia (flutter/engine#20983)

* b22a8c6 Let FlutterActivity/Fragment/FragmentActivity have an app bundle path override instead of eager resolving during construction (flutter/engine#20769)

* 0f0ae68 Update test Dart code to pass the latest Dart analyzer rules (flutter/engine#20986)

* d77dd31 Manual roll of Dart b29f228f62...016e8880f0 (flutter/engine#20967)

* c7b3d53 Roll Fuchsia Mac SDK from gOI3W1UNU... to EN2ycWLxi... (flutter/engine#20985)

* 6a6986d improve sensitivity of BackdropFilter web tests (flutter/engine#20915)

* 9fc9cb2 Roll Dart SDK from 016e8880f0ab to 0f0cff3922ad (7 revisions) (flutter/engine#20990)

* 242d522 [Android R] Sync keyboard animation with view insets vs Android 11/R/API 30 WindowInsetsAnimation (flutter/engine#20843)

* b4e0896 Roll Fuchsia Linux SDK from 81O8Kg_Rw... to A0PKwETay... (flutter/engine#20998)

* d77c4e5 adjust blur radius for HTML to match CanvasKit (flutter/engine#20840)

* 0628492 Roll Dart SDK from 0f0cff3922ad to f3a9ca88b664 (1 revision) (flutter/engine#21000)

* d1d848e Roll Fuchsia Mac SDK from EN2ycWLxi... to sih5f60Gt... (flutter/engine#20999)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov Awaiting requested review from yjbanov

@aam aam Awaiting requested review from aam

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@a-siva @aam @googlebot