Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@matthew-carroll
Copy link
Contributor

Adds the ability to linearly interpolate Durations.

@matthew-carroll
Copy link
Contributor Author

@cbracken @Hixie I have a question on testing for this PR. I did a search through the testing/dart directory in the engine repo and didn't find any existing tests for lerpDouble, which is where I planned to add tests for lerpDuration. Any idea if those tests are located somewhere else, or if we simply don't have any such tests?

@cbracken
Copy link
Member

Nice catch. Thanks for spotting this! Just sent #20778 which adds tests for lerpDouble.

@Hixie
Copy link
Contributor

Hixie commented Aug 26, 2020

Would it make more sense to put this in the foundation library of the flutter framework? Generally we try to keep dart:ui as small as possible and so we only put things here that we need to have here. (If there's a reason to have it here of course that's fine.)

@matthew-carroll
Copy link
Contributor Author

@Hixie sure, I can move it. I just went immediately to where lerpDouble was located, but I'll move it to foundation.

@matthew-carroll
Copy link
Contributor Author

Closing in favor of an implementation in Foundation instead of dart:ui:
flutter/flutter#64668

@cbracken cbracken deleted the add_support_for_lerpDuration branch May 10, 2022 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants