Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix EGL_BAD_SURFACE when app is paused #20735

Merged
blasten merged 1 commit into from
Aug 25, 2020
Merged

Fix EGL_BAD_SURFACE when app is paused #20735

blasten merged 1 commit into from
Aug 25, 2020

Conversation

@blasten
Copy link

@blasten blasten commented Aug 24, 2020 •
edited
Loading

Description

When the app is paused, the native Surface window is destroyed. Then, it's reset back when the app is resumed.

Related Issues

Fixes flutter/flutter#64414

Tests

There isn't a good way to test this at the moment.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@blasten blasten requested a review from chinmaygarde August 24, 2020 21:44
@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 24, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@auto-assign auto-assign bot requested a review from jason-simmons August 24, 2020 21:45
@blasten blasten merged commit 45f0940 into flutter:master Aug 25, 2020
@blasten blasten deleted the fix_null_surface branch August 25, 2020 19:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 26, 2020
@engine-flutter-autoroll
45f0940 Fix EGL_BAD_SURFACE when app is paused (flutter/engine#20735)
ce108b5
@zanderso
Copy link
Member

zanderso commented Aug 26, 2020

What are the blockers to having a regression test for this?

@blasten
Copy link
Author

blasten commented Aug 26, 2020

@zanderso we would need an emulator with this specific version of Android. I wired up the emulators on LUCI and it’s relatively easy to add a new emulator. Then, the scenario app activity could be launched, paused and resumed.

@christopherfujino christopherfujino mentioned this pull request Aug 26, 2020
Merged
christopherfujino added a commit that referenced this pull request Aug 27, 2020
@christopherfujino @jason-simmons
Flutter Beta 1.21.0-9.2.pre cherry picks (#20797)
20a9531 
* update dart revision
* Fix EGL_BAD_SURFACE when app is paused (#20735)
* The `ForwardingGestureRecognizers` to have back reference to the `PlatformViewsController` so it can access `FlutterViewController` when its available  (#20708)
* Remove image sizes from Picture::GetAllocationSize (#20673)
* update licenses golden

Co-authored-by: Emmanuel Garcia <[email protected]>
Co-authored-by: Chris Yang <[email protected]>
Co-authored-by: Jason Simmons <[email protected]>
@pedromassangocode pedromassangocode mentioned this pull request Aug 28, 2020
Closed
@christopherfujino christopherfujino mentioned this pull request Aug 29, 2020
Merged
christopherfujino added a commit that referenced this pull request Aug 31, 2020
@christopherfujino
Flutter 1.20.3 engine cherrypicks (#20838)
d1bc06f 
* Update 1.20 engine to use Dart 2.9.2
* update license goldens
* Fix EGL_BAD_SURFACE when app is paused (#20735)
* The `ForwardingGestureRecognizers` to have back reference to the `PlatformViewsController` so it can access `FlutterViewController` when its available  (#20708)
* cherry-pick e09af86
* skip linting since this was enabled in CI after this release branch cut commit.

Co-authored-by: Emmanuel Garcia <[email protected]>
Co-authored-by: Chris Yang <[email protected]>
@b055man
Copy link

b055man commented Sep 4, 2020 •
edited
Loading

@christopherfujino @blasten Is this fix actually in 1.20.3? I can't see it mentioned in the notes for 1.20.3, also the diff does not show it..
flutter/flutter@1.20.2...1.20.3
[EDIT] nevermind, I now see it's a part of the engine, and the engine version has been updated..
For future, it'd be good though to reference the engine fixes in the release notes too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

1 more reviewer

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

App freezes when switching via task switcher on API 25 - Android 7.1.1

5 participants

@blasten @zanderso @b055man @jason-simmons @googlebot