Update to android 30r2 and roll buildroot #20479
Conversation
| embedding_deps_dir = os.path.join(buildroot_dir, 'third_party', 'android_embedding_dependencies', 'lib') | ||
| classpath = map(str, [ | ||
| os.path.join(buildroot_dir, 'third_party', 'android_tools', 'sdk', 'platforms', 'android-29', 'android.jar'), | ||
| os.path.join(buildroot_dir, 'third_party', 'android_tools', 'sdk', 'platforms', 'android-30', 'android.jar'), |
There was a problem hiding this comment.
|
LGTM, thanks |
|
Anyone know why https://ci.chromium.org/p/flutter/builders/try/Windows%20Host%20Engine/11910? |
|
flutter/buildroot@97f6f00 is probably causing this. cc @stuartmorgan |
|
Sorry, everything was green in my test run before landing that buildroot change, but then once I actually tried to roll with the real builroot it's been failing unit tests (I suspect it's throwing an exception, which the Windows CI seems to treat as a hang instead). Feel free to revert the VS 2019 change to unblock your roll. |
GaryQian
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
|
Landing, Mac iOS Engine passes on rerun: https://ci.chromium.org/p/flutter/builders/try/Mac%20iOS%20Engine/7182 |
6 participants
Fixes flutter/flutter#56597
This upgrades to default to building with Android 30. Also uses platform-tools 30.0.4 and build-tools 30.0.1