-
Notifications
You must be signed in to change notification settings - Fork 6k
Engine 1.20.2 cherrypicks #20446
Engine 1.20.2 cherrypicks #20446
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
|
format_and_dart_test failure is expected on 1.20 (still) |
|
The Mac iOS engine screenshot test failure looks suspicious. I'm going to give it a try locally. |
|
@cyanglaz any update? |
|
The image comparison logic failed in this PR because 91f80ef is not in 1.20, which fixes the image diff logic in the scenario app. |
…n golden image tests (flutter#19658) Moved to RMSE for image comparison to account for slight variations in golden image production. (also fixed a flakey test)
cyanglaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Uh oh!
There was an error while loading. Please reload this page.