This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix flutter#40068 Redraw issues on resize/minimize/maximize on Windows and startup in release #20357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
12 tasks
stuartmorgan-g
suggested changes
Aug 10, 2020
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Awesome! Thanks for tracking this down and fixing it :)
stuartmorgan-g
suggested changes
Aug 17, 2020
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
This version doesn't build; see CI errors.
Author
|
Before i address final comment, confirming that the fix still works as expected with ToT |
stuartmorgan-g
approved these changes
Aug 19, 2020
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM!
I think you'll need to merge master again when it's green; it looks like you picked up a Linux error from the last merge.
clarkezone
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2020
…n Windows and startup in release (flutter/engine#20357)
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Aug 20, 2020
…s and startup in release (flutter#20357) * Fix redraw issues * Address CR feedback. * Fix build * CR feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes flutter/flutter#40068. The root cause of the issue was a race condition in resize and release mode startup scenarios where frame rendering operations were getting stomped on by automatic DirectX swapchain resize happening in the Angle layer.
This change disables automatic swapchain resizing in Angle and instead performs an explicit resize operation before the engine is told about size changes thus guaranteeing that the race condition isn't possible anymore.
The change fixes a related secondary issue uncovered in the ordering of rendering initialization in startup on Windows contributing to flutter/flutter#63299. An additional fix for the latter will be submitted to flutter/flutter once this change has landed.
Related Issues
flutter/flutter#63299
Tests
I added the following tests:
No behavior changed in this PR
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.