This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Eagerly calculate relevant indices during line break detection #20278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
mdebbar
commented
Aug 6, 2020
yjbanov
approved these changes
Aug 6, 2020
ferhatb
approved these changes
Aug 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the text measurement process, we do multiple lookbacks at each chunk of text to check for trailing spaces and new lines. With this PR, we eagerly track spaces and new lines during the line break detection phase. This ensures we only take one pass at the text and no extra iterations.
The main purpose of this PR was cleanup but it's nice to get some bonus perf improvements as well. In the
text_canvas_color_gridbenchmark we got the following improvements:Tests
This is a pure refactoring PR, so I'm relying on the existing comprehensive tests in:
test/text/line_breaker_test.darttest/text/measurement_test.darttest/paragraph_test.dart