Replace the legacy pointer input event handling with PointerPackets #2021
Conversation
There was a problem hiding this comment.
This DartInvokeField acts as an embedder entry point. //sky/engine/bindings/dart_vm_entry_points.txt needs to be updated.
|
lgtm. I really like flushing all pending pointer events in one go. I will update the iOS platform stuff once this lands. |
|
LGTM |
|
You'll also need to update |
|
sky_viewer.mojo doesn't talk to the legacy view manager (or any other view manager), it talks to native viewport. The input events it gets are https://github.com/domokit/mojo/blob/master/mojo/services/input_events/interfaces/input_events.mojom instances from the NativeViewportEventDispatcher interface: https://github.com/domokit/mojo/blob/master/mojo/services/native_viewport/interfaces/native_viewport.mojom#L50 |
|
@jamesr Yes, you're right. At some point, we should probably teach NativeViewportEventDispatcher (and eventually Mozart) about pointer packets. |
jason-simmons
force-pushed
the
idl_pointer_event
branch
from
3918a1f to
fcbffef
Compare
With this change we no longer need engine/core/events and its IDL bindings.
jason-simmons
force-pushed
the
idl_pointer_event
branch
from
fcbffef to
9f2d723
Compare
|
A few updates:
|
|
LGTM |
Replace the legacy pointer input event handling with PointerPackets
…e-typedef-functions Improve the highlight range for avoid_private_typedef_functions
4 participants
With this change we no longer need engine/core/events and its IDL bindings.