Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Jul 17, 2020

Remove obsolete check on FlutterPlatformViewsController::OnCreate (#19819)

Remove obsolete check on FlutterPlatformViewsController::OnCreate (flutter#19819)
@dnfield dnfield requested a review from pcsosinski July 17, 2020 17:43
@fluttergithubbot fluttergithubbot changed the base branch from flutter-1.20-candidate.7 to master July 17, 2020 17:43
@fluttergithubbot
Copy link
Contributor

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@dnfield dnfield changed the base branch from master to flutter-1.20-candidate.7 July 17, 2020 17:44
@auto-assign auto-assign bot requested a review from chinmaygarde July 17, 2020 17:44
@dnfield
Copy link
Contributor Author

dnfield commented Jul 17, 2020

* adding a script for web_analysis for using from luci.

* addressing reviewer comments
@dnfield
Copy link
Contributor Author

dnfield commented Jul 17, 2020

Also picking da8defd to get a new script the web builders want (/cc @nturgut )

This will fail the framework analysis because framework master has been updated for a rev of dart not contained in this branch.

@nturgut
Copy link
Contributor

nturgut commented Jul 17, 2020

Also picking da8defd to get a new script the web builders want (/cc @nturgut )

This will fail the framework analysis because framework master has been updated for a rev of dart not contained in this branch.

Thanks a lot for the cherrypick.

@christopherfujino
Copy link
Contributor

updated cirrus.yml to checkout the right framework branch

@dnfield
Copy link
Contributor Author

dnfield commented Jul 17, 2020

This is all green. LGTY @christopherfujino or do you still have to update the CIPD stuff?

@dnfield
Copy link
Contributor Author

dnfield commented Jul 17, 2020

I'm going to merge assuming this is all ok. We can retag CIPD if needed.

@dnfield dnfield merged commit c964bf6 into flutter:flutter-1.20-candidate.7 Jul 17, 2020
@dnfield dnfield deleted the flutter-1.20-candidate.7 branch July 17, 2020 22:55
@christopherfujino
Copy link
Contributor

sorry, just saw this now. it's good to go, though 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants