-
Notifications
You must be signed in to change notification settings - Fork 6k
Add support for horizontalDoubleArrow and verticalDoubleArrow cursors #18916
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
The code looks good. |
|
Do we support the resize-nw cursor right now? The top/bottom usages I've seen refer to regions, whereas this refers to directionality. Is there a case where we use top/bottom for directionality? |
Not yet, but only because of low priority, the same as these two cursors.
You're right. So what name do you think they would be (as well as diagnal cursors such as |
FYI, diagonal resize aren't system cursors on macOS, so if we want to support them it'll require custom embedding support. |
|
Maybe |
|
There are lots of cursors that aren't shared between platforms. The plan is to make them fall back to other cursors, such as the basic cursor, so that the superset of all cursors is available to the framework by all platforms, although some don't work in the best way. In other words, having diagnal resize cursors in the framework doesn't mean they will be supported by all platforms, but only that they will be supported by some platforms. |
Description
This adds engine support for the resize up-down and resize left-right cursors, which enable
callers to build a splitter widget.
Checklist
Breaking Change