This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Record path memory usage in SkPictures #18827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Now, that |
chinmaygarde
approved these changes
Jun 4, 2020
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Discussed in chat that updates recommended in to DartWrappable can be made in a subsequent patch. In that case, this is fine in the interim.
Contributor
Author
|
Redness is an infra flake. Going to land this. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Path portion of flutter/flutter#58438
GetAllocationSize will only really help in cases where the path is already set up, e.g. for
transform,shift, andclone. It will not help as much in the normal case of creating a new path and adding drawing commands to it. For that, we could consider using some new Dart API to update the size.However, we can at least get better collection around SkPictures - once the path has been drawn to the picture, the picture will use the memory of those path commands.
Related Issues
flutter/flutter#58438
Tests
I added the following tests:
Test that
canvasmethods involving paths add the size appropriately to the resultant picture.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.