This repository was archived by the owner on Feb 25, 2025. It is now read-only.
null annotate window.dart #18789
Merged
null annotate window.dart #18789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Jun 3, 2020
| case 'yuu': | ||
| return 'yug'; // Yugh; deprecated 2014-02-28 | ||
| default: | ||
| return languageCode; |
Member
There was a problem hiding this comment.
The behavior here looks like it might be different. Is it intentional? Does it matter?
Contributor
Author
There was a problem hiding this comment.
What's the difference in the behavior? If I'm reading the code correctly, both versions will attempt to map a deprecated value to the new value, and default to _languageCode otherwise.
Member
There was a problem hiding this comment.
Ah, you're right. I missed the ?? _languageCode on the getter.
| case 'ZR': | ||
| return 'CD'; // Zaire; deprecated 1997-07-14 | ||
| default: | ||
| return regionCode; |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
window.dart.webOnlyScheduleFrameCallbackfromdart:uitodart:_engine._deprecatedLanguageSubtagMapand_deprecatedRegionSubtagMapfrom mobile into the web version.Related Issues
flutter/flutter#53661