This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Minimize child DOM node moves in many-to-many update #18648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
force-pushed
the
many-to-many
branch
2 times, most recently
from
f6e3eae to
41b568c
Compare
ferhatb
approved these changes
Jun 1, 2020
| for (int i = 0; i < newUnfilteredChildCount; i++) { | ||
| final PersistedSurface child = _children[i]; | ||
| if (child.isCreated) { | ||
| if (child.isCreated && !(child is PersistedContainerSurface && child.oldLayer != null)) { |
Contributor
There was a problem hiding this comment.
add comment for oldLayer check pls.
Contributor
Author
There was a problem hiding this comment.
Done. I also removed the is check by moving the oldLayer field to PersistedSurface (it's just that leaf layers always keep it as null).
ferhatb
approved these changes
Jun 2, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2020
This was referenced Jun 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change many-to-many child node update to move as few elements as possible. This captures many more cases than the previous naive implementation did. In particular it improves backwards scrolling by 15%-25% (see e.g. flutter/flutter#55922).
Below are A/B benchmark results from our infinite scrolling benchmark (I'm adding the backwards scrolling variant in flutter/flutter#58140).
I will consider that this fixes flutter/flutter#55922, as backwards scrolling was the single biggest issue I've seen in that case. We can open more specific issues for the remaining work.