Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

fuchsia: Fix runtime_tests and shell_tests #18492

Merged
fluttergithubbot merged 3 commits into from
May 21, 2020
Merged

fuchsia: Fix runtime_tests and shell_tests #18492

fluttergithubbot merged 3 commits into from
May 21, 2020

Conversation

@arbreng
Copy link
Contributor

@arbreng arbreng commented May 19, 2020 •
edited
Loading

Tested: Ran unittests on host and fuchsia w/ repeat=10000; ran workstation
Fixes: flutter/flutter#50032
Fixes: flutter/flutter#57124

@arbreng arbreng requested review from gw280 and iskakaushik May 19, 2020 00:56
@iskakaushik
Copy link
Contributor

iskakaushik commented May 20, 2020

Could you please uncomment the last two blocks in https://github.com/flutter/engine/blob/master/testing/fuchsia/run_tests.sh? Thanks!

@arbreng arbreng force-pushed the fix-fuchsia-unittests branch from 072c05a to 6576fc8 Compare May 20, 2020 22:46
@arbreng arbreng requested a review from chinmaygarde May 20, 2020 22:52
@arbreng arbreng force-pushed the fix-fuchsia-unittests branch from 6576fc8 to 607f1f3 Compare May 21, 2020 00:44
@iskakaushik iskakaushik added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 21, 2020
@fluttergithubbot fluttergithubbot merged commit 1429534 into flutter:master May 21, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2020
@engine-flutter-autoroll
1429534 fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492
36dbd27 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2020
@engine-flutter-autoroll
1429534 fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492
c5c301b 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
1429534 fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492
14f7a29 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
1429534 fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492
482fc37 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
1429534 fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492
2aead23 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
1429534 fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492
17f3667 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
1429534 fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492
752ea4c 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
1429534 fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492
8ca1b19 
)
wandyers pushed a commit to wandyers/engine that referenced this pull request May 23, 2020
@arbreng @wandyers
fuchsia: Fix runtime_tests and shell_tests (flutter#18492)
7218667
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2020
@engine-flutter-autoroll
1429534 fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492
c8265a5 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2020
@engine-flutter-autoroll
1429534 fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492
ab187b5 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2020
@engine-flutter-autoroll
1429534 fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492
d8e3c14 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2020
@engine-flutter-autoroll
1429534 fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492
d4d8824 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2020
@engine-flutter-autoroll
1429534 fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492
f8e592c 
)
liyuqian added a commit to liyuqian/flutter that referenced this pull request May 26, 2020
@liyuqian
Roll Engine from 9ce1e5c to 1a83498 (69 revisions)
0516672 
Roll Engine from 9ce1e5c to 1a83498 (69 revisions)

flutter/engine@9ce1e5c...1a83498

2020-05-26 [email protected] Revert "Update CanvasKit to 0.15.0 (flutter#18570)" (flutter/engine#18600)
2020-05-26 [email protected] Roll Fuchsia Mac SDK from TSEOq... to hr-HZ... (flutter/engine#18594)
2020-05-26 [email protected] Roll Dart SDK from 65113fd73dec to 9e3b0289197d (2 revisions) (flutter/engine#18593)
2020-05-26 [email protected] Roll Skia from b6d158aaf3dd to e4b4ca1050b9 (1 revision) (flutter/engine#18592)
2020-05-26 [email protected] Roll Fuchsia Linux SDK from DzG49... to pLp67... (flutter/engine#18591)
2020-05-24 [email protected] Roll Fuchsia Mac SDK from Oz016... to TSEOq... (flutter/engine#18590)
2020-05-23 [email protected] Roll Skia from afd8a6c6ae87 to b6d158aaf3dd (3 revisions) (flutter/engine#18588)
2020-05-22 [email protected] Roll Fuchsia Mac SDK from 99Z4_... to Oz016... (flutter/engine#18582)
2020-05-22 [email protected] Roll Skia from ec31488ace66 to afd8a6c6ae87 (1 revision) (flutter/engine#18581)
2020-05-22 [email protected] Roll Fuchsia Linux SDK from Kvwlr... to DzG49... (flutter/engine#18580)
2020-05-22 [email protected] Roll Skia from 80abb89c3632 to ec31488ace66 (1 revision) (flutter/engine#18579)
2020-05-22 [email protected] Roll Skia from da90c3765908 to 80abb89c3632 (4 revisions) (flutter/engine#18577)
2020-05-22 [email protected] Roll Fuchsia Mac SDK from _zNmv... to 99Z4_... (flutter/engine#18576)
2020-05-22 [email protected] Roll Skia from 317dce5c81c0 to da90c3765908 (1 revision) (flutter/engine#18575)
2020-05-22 [email protected] Roll Dart SDK from 4ee57c08e0a6 to 65113fd73dec (3 revisions) (flutter/engine#18574)
2020-05-22 [email protected] Roll Skia from 67e21a19259b to 317dce5c81c0 (3 revisions) (flutter/engine#18573)
2020-05-22 [email protected] Update CanvasKit to 0.15.0 (flutter/engine#18570)
2020-05-21 [email protected] Roll Skia from 3d52abc84667 to 67e21a19259b (1 revision) (flutter/engine#18568)
2020-05-21 [email protected] Roll Dart SDK from 396b5fb7a97d to 4ee57c08e0a6 (6 revisions) (flutter/engine#18567)
2020-05-21 [email protected] Add fl_value_to_string (flutter/engine#18540)
2020-05-21 [email protected] Roll Skia from 1e63279156d6 to 3d52abc84667 (5 revisions) (flutter/engine#18566)
2020-05-21 [email protected] null-annotate semantics.dart (flutter/engine#18553)
2020-05-21 [email protected] Roll Fuchsia Linux SDK from ciqRH... to Kvwlr... (flutter/engine#18565)
2020-05-21 [email protected] Roll Skia from b37105ea6cca to 1e63279156d6 (9 revisions) (flutter/engine#18564)
2020-05-21 [email protected] Implement WriteAtomically using write/fsync on all platforms, and enable (flutter/engine#18320)
2020-05-21 [email protected] Roll Dart SDK from ecce58c1e354 to 396b5fb7a97d (2 revisions) (flutter/engine#18560)
2020-05-21 [email protected] Roll Fuchsia Mac SDK from RNByJ... to _zNmv... (flutter/engine#18558)
2020-05-21 [email protected] [profiling] Memory Profiling support for iOS (flutter/engine#18516)
2020-05-21 [email protected] Roll Skia from 22636205ce92 to b37105ea6cca (2 revisions) (flutter/engine#18557)
2020-05-21 [email protected] Roll Dart SDK from d551980ac9fc to ecce58c1e354 (2 revisions) (flutter/engine#18556)
2020-05-21 [email protected] Roll Dart SDK from bf7e9d13d730 to d551980ac9fc (6 revisions) (flutter/engine#18551)
2020-05-21 [email protected] Roll Skia from 4c0578632217 to 22636205ce92 (4 revisions) (flutter/engine#18550)
2020-05-21 [email protected] Roll Fuchsia Linux SDK from ThMeW... to ciqRH... (flutter/engine#18549)
2020-05-21 [email protected] Roll Skia from 67ff541ac116 to 4c0578632217 (1 revision) (flutter/engine#18547)
2020-05-21 [email protected] Let run_tests.py just stream output (flutter/engine#18534)
2020-05-21 [email protected] Add FlKeyEventPlugin (flutter/engine#18313)
2020-05-21 [email protected] Add tests for StandardMethodCodec (flutter/engine#18521)
2020-05-21 [email protected] Roll Skia from f83baf230c69 to 67ff541ac116 (1 revision) (flutter/engine#18545)
2020-05-21 [email protected] Roll Fuchsia Mac SDK from 3o9aQ... to RNByJ... (flutter/engine#18543)
2020-05-21 [email protected] fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492)
2020-05-21 [email protected] Roll Skia from d2dc8ddcdf5e to f83baf230c69 (2 revisions) (flutter/engine#18539)
2020-05-21 [email protected] Roll Dart SDK from 7aa8656d1dd8 to bf7e9d13d730 (21 revisions) (flutter/engine#18538)
2020-05-21 [email protected] Add FlMethodChannel, FlMethodCodec, FlStandardMethodCodec and FlJsonMethodCodec (flutter/engine#18220)
2020-05-20 [email protected] [web] Fix arc rendering when it starts a new sub path. (flutter/engine#18535)
2020-05-20 [email protected] Send platformResolvedLocale from iOS embedder (flutter/engine#18519)
2020-05-20 [email protected] System mouse cursor: macOS (flutter/engine#18131)
...
@liyuqian liyuqian mentioned this pull request May 26, 2020
Closed
@arbreng arbreng deleted the fix-fuchsia-unittests branch June 30, 2020 00:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

@gw280 gw280 Awaiting requested review from gw280

1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

affects: engine bug cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

5 participants

@arbreng @iskakaushik @chinmaygarde @googlebot @fluttergithubbot