This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] add robust scheduling for flutter_runner #18233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelpessa
approved these changes
May 8, 2020
shell/platform/fuchsia/flutter/tests/session_connection_unittests.cc
Outdated
Show resolved
Hide resolved
dreveman
approved these changes
May 29, 2020
farchond
force-pushed
the
robust_scheduling
branch
from
4a75565 to
0b62788
Compare
dreveman
approved these changes
Jun 2, 2020
Added tests
farchond
force-pushed
the
robust_scheduling
branch
from
56231cd to
a607ca8
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2020
This was referenced Jun 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we request a presentation time of 0 for all frames, thus relying on wakeup ordering between Flutter and Scenic to have reasonable behavior. This is unreliable at best, and necessitates coordination between Flutter and Scenic code changes in order to not regress performance.
This PR enables Flutter to instead target frame times based on information returned every vsync interval from Scenic. No change in performance is expected, as we're still targeting the same vsyncs, only now we're doing so explicitly.