This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Bumped up the timeout for testAccessibilityFocusOnTextSemanticsProducesCorrectIosViews #17988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esCorrectIosViews
Member
Author
|
@xster I made those changes we discussed over VC. |
xster
reviewed
Apr 28, 2020
| FLUTTER_ASSERT_ARC | ||
|
|
||
| @interface XCUIElement (ftr_waitForNonExistence) | ||
| /// Keeps waiting until the element doesn't exist. Returns NO if the timeout is |
Member
There was a problem hiding this comment.
keep waiting until the element no longe exists?
Member
Author
There was a problem hiding this comment.
That sounds like it has to exist beforehand. The implementation is agnostic to that.
Member
|
LGTM |
Member
Author
|
Landing before Windows Web Engine finishes, it passed previously. I just removed some print statements since then. |
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
…csProducesCorrectIosViews (flutter/engine#17988)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
…csProducesCorrectIosViews (flutter/engine#17988)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
…csProducesCorrectIosViews (flutter/engine#17988)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2020
…csProducesCorrectIosViews (flutter/engine#17988)
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: flutter/flutter#55778