This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add initial unit tests for the android embedding #17921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Apr 24, 2020
|
|
||
| import("//flutter/testing/testing.gni") | ||
|
|
||
| source_set("external_view_embedder") { |
Member
There was a problem hiding this comment.
It may be a good idea now to start thinking about unifying all the external view embedder implementations into a common utility that can be configured per the needs of specific embedders. Once fully realized, this is going to look very similar to the iOS and custom embedder implementations. And, at least the custom embedder implementation has a tests that may be useful for this effort.
Member
There was a problem hiding this comment.
This is an excellent clean start to a clean room implementation however. So feel free to bring in the other stuff later.
Author
There was a problem hiding this comment.
For sure. This change will help shape the next action items. :)
added 3 commits
April 24, 2020 18:26
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 27, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 27, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 27, 2020
This was referenced Apr 27, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 27, 2020
This was referenced Apr 27, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
This was referenced Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
This was referenced Apr 28, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial unit tests to the Android external view embedder. I created a separate package the
shell/platform/android:*cannot be compiled with the host toolchain.Fixes flutter/flutter#55269