Port sky viewer to new view manager. #1771
Conversation
There was a problem hiding this comment.
Haha! Let's refactor that next. :)
On Fri, Oct 23, 2015, 8:55 PM Adam Barth [email protected] wrote:
In services/sky/content_handler_impl.cc
#1771 (comment):#include "services/sky/document_view.h"
namespace sky {
+class SkyViewProvider : public mojo::InterfaceFactorymojo::ui::ViewProvider,
FlutterViewProvider ?
—
Reply to this email directly or view it on GitHub
https://github.com/flutter/engine/pull/1771/files#r42929925.
|
This looks great. LGTM. At some point, once the dust has settled on the new view manager, I'd like to refactor/rewrite this code. It should be possible to delete all this code and integrate mojo with the |
|
Yup. Sounds good to me. On Fri, Oct 23, 2015, 9:48 PM Adam Barth [email protected] wrote:
|
…VM (flutter#1771) * GNU coreutils force-enabling line buffering instead of depending on VM to do buffering right * remove debugging and wrong show-progress * core dumps on * pub get in script? * skip install on macos * syntax error fix * travis * fix syntax * Remove if statement * Fix up travis hack for better usefulness for dartdoc, and disable the hack on macos * Make install_travis not return non-zero
update to relative imports
2 participants
Requires a fresh roll from Mojo repo before submitting.