This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll Dart to revision 2.7.2, remove duplicate dependencies #17306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 24, 2020 10:38
Member
|
There is still an additional missing entry. Applying https://gist.github.com/chinmaygarde/21b1ada2f344486386022828e7800278 allows me to build this branch locally. |
pcsosinski
changed the title
christopherfujino
approved these changes
Mar 26, 2020
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM. We are ignoring LUCI presubmit failures as they are using the latest master. Post-submit should use the hotfix builders, and should pass.
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
details: https://docs.google.com/document/d/1qTFdBeMaIa6wvvdyrSRtYDpgotxuz9gpBshgqrQsh1w/edit?hl=en#