Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@skia-flutter-autoroll
Copy link
Contributor

https://dart.googlesource.com/sdk.git/+log/ba8baa46b452..fbd0c8a46813

git log ba8baa4..fbd0c8a --date=short --first-parent --format='%ad %ae %s'
2020-03-20 [email protected] Migration: mark for-each loop variables as initialized
2020-03-20 [email protected] Migration: use prefixes when introducing "as" expressions
2020-03-20 [email protected] [ Service ] Bump package:test timeout to 10 minutes for VM service tests
2020-03-20 [email protected] Remove unittest from DEPS, .packages, package_config.json
2020-03-20 [email protected] Migrator: Improve scrolling behavior for elements near top or bottom
2020-03-20 [email protected] Update the README based on meeting notes
2020-03-20 [email protected] [tests] Add language version comment ddc tests
2020-03-20 [email protected] [dart2js] Handle NullableType from createFromStaticType
2020-03-20 [email protected] null-safety fixes for ListCopy benchmark setup
2020-03-20 [email protected] Allow null arguments to tearoffInterop
2020-03-20 [email protected] NNDB: dart:collection Fix ListMixin operator+
2020-03-20 [email protected] Migration: handle field overrides
2020-03-20 [email protected] Reland "[ VM / Service ] Migrated Observatory service tests from package:unittest to package:test and package:expect."
2020-03-20 [email protected] Prepare analysis_server_client for isolate implementation.
2020-03-20 [email protected] [vm] Disable integer division on Android ARM emulators
2020-03-20 [email protected] Fix static errors in nnbd_js_interop_test
2020-03-20 [email protected] Migrator: fix test to assert on information region when not making a parameter nullable
2020-03-20 [email protected] [nnbd migration] initial mogration workflow docs
2020-03-20 [email protected] Convert from _JsonMap to Map<String, Object> in corelib/map_entry_test
2020-03-20 [email protected] Add missing null checks for return values from AstNode.findPrevious(..)
2020-03-20 [email protected] [vm/nnbd] Run kernel-service and vm-service isolates in NNBD weak mode
2020-03-20 [email protected] Unittest is finally going the way of the dinosaurs.
2020-03-20 [email protected] Add some additional tests to test the commands that are currently passing the help == --help assertion.
2020-03-20 [email protected] Adjust tests where a TypeError may occur to also expect ArgumentError
2020-03-20 [email protected] [nnbd] Fix remaining analyzer issues in dart:io and dart:_http.
2020-03-20 [email protected] quickfix for prefer_const_constructors_in_immutables
2020-03-20 [email protected] [cfe] Don't include Function in Class.supertype and Class.implementedTypes
2020-03-20 [email protected] Issue 41095. Update flatten() to null safety.
2020-03-20 [email protected] [dart2js] fix in normalization
2020-03-20 [email protected] [mirrors] Explicitly use the new signature of Object.==.
2020-03-20 [email protected] [dart2js] Fix storing non-JsObject in property.
2020-03-20 [email protected] [WATCHLISTS] Remove johnniwinther@ from dart2js watchlist
2020-03-20 [email protected] [vm/compiler] Compiler::CompileFunction can no longer fallback to Precompiler::CompileFunction
2020-03-20 [email protected] [vm/aot] Add VM entry point annotation to _CompactLinkedHashSet.
2020-03-20 [email protected] Bump DEPS for pub to include pub outdated

Created with:
gclient setdep -r src/third_party/dart@fbd0c8a46813

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]

https://dart.googlesource.com/sdk.git/+log/ba8baa46b452..fbd0c8a46813

git log ba8baa4..fbd0c8a --date=short --first-parent --format='%ad %ae %s'
2020-03-20 [email protected] Migration: mark for-each loop variables as initialized
2020-03-20 [email protected] Migration: use prefixes when introducing "as" expressions
2020-03-20 [email protected] [ Service ] Bump package:test timeout to 10 minutes for VM service tests
2020-03-20 [email protected] Remove unittest from DEPS, .packages, package_config.json
2020-03-20 [email protected] Migrator: Improve scrolling behavior for elements near top or bottom
2020-03-20 [email protected] Update the README based on meeting notes
2020-03-20 [email protected] [tests] Add language version comment ddc tests
2020-03-20 [email protected] [dart2js] Handle NullableType from createFromStaticType
2020-03-20 [email protected] null-safety fixes for ListCopy benchmark setup
2020-03-20 [email protected] Allow null arguments to tearoffInterop
2020-03-20 [email protected] NNDB: dart:collection Fix ListMixin operator+
2020-03-20 [email protected] Migration: handle field overrides
2020-03-20 [email protected] Reland "[ VM / Service ] Migrated Observatory service tests from package:unittest to package:test and package:expect."
2020-03-20 [email protected] Prepare analysis_server_client for isolate implementation.
2020-03-20 [email protected] [vm] Disable integer division on Android ARM emulators
2020-03-20 [email protected] Fix static errors in nnbd_js_interop_test
2020-03-20 [email protected] Migrator: fix test to assert on information region when not making a parameter nullable
2020-03-20 [email protected] [nnbd migration] initial mogration workflow docs
2020-03-20 [email protected] Convert from _JsonMap to Map<String, Object> in corelib/map_entry_test
2020-03-20 [email protected] Add missing null checks for return values from AstNode.findPrevious(..)
2020-03-20 [email protected] [vm/nnbd] Run kernel-service and vm-service isolates in NNBD weak mode
2020-03-20 [email protected] Unittest is finally going the way of the dinosaurs.
2020-03-20 [email protected] Add some additional tests to test the commands that are currently passing the help <verb> == <verb> --help assertion.
2020-03-20 [email protected] Adjust tests where a TypeError may occur to also expect ArgumentError
2020-03-20 [email protected] [nnbd] Fix remaining analyzer issues in dart:io and dart:_http.
2020-03-20 [email protected] quickfix for `prefer_const_constructors_in_immutables`
2020-03-20 [email protected] [cfe] Don't include Function in Class.supertype and Class.implementedTypes
2020-03-20 [email protected] Issue 41095. Update flatten() to null safety.
2020-03-20 [email protected] [dart2js] fix in normalization
2020-03-20 [email protected] [mirrors] Explicitly use the new signature of Object.==.
2020-03-20 [email protected] [dart2js] Fix storing non-JsObject in property.
2020-03-20 [email protected] [WATCHLISTS] Remove johnniwinther@ from dart2js watchlist
2020-03-20 [email protected] [vm/compiler] Compiler::CompileFunction can no longer fallback to Precompiler::CompileFunction
2020-03-20 [email protected] [vm/aot] Add VM entry point annotation to _CompactLinkedHashSet.
2020-03-20 [email protected] Bump DEPS for pub to include `pub outdated`

Created with:
  gclient setdep -r src/third_party/dart@fbd0c8a46813

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: [email protected]
@skia-flutter-autoroll skia-flutter-autoroll added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 21, 2020
@fluttergithubbot fluttergithubbot merged commit 047c03b into flutter:master Mar 21, 2020
yjbanov added a commit to yjbanov/engine that referenced this pull request Mar 21, 2020
…ter#17241)"

This reverts commit 047c03b.

This roll also breaks web tests with:

```
org-dartlang-app:///test/material/icon_button_test.dart:15:7: Warning: Implementing 'Function' is deprecated.
Try removing 'Function' from the 'implements' clause.
class MockOnPressedFunction implements Function {
```
yjbanov added a commit that referenced this pull request Mar 21, 2020
…)" (#17243)

This reverts commit 047c03b.

This roll also breaks web tests with:

```
org-dartlang-app:///test/material/icon_button_test.dart:15:7: Warning: Implementing 'Function' is deprecated.
Try removing 'Function' from the 'implements' clause.
class MockOnPressedFunction implements Function {
```
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants