This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Soften shadows #17231
Merged
Soften shadows #17231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatb
approved these changes
Mar 20, 2020
|
|
||
| import 'scuba.dart'; | ||
|
|
||
| const Color _kShadowColor = Color.fromARGB(255, 255, 0, 0); |
Contributor
Author
There was a problem hiding this comment.
Making the shadows softer made the red color too subtle in the golden test, so I decided to switch the test to pitch black. Also, black shadows are the most commonly used ones.
yjbanov
force-pushed
the
aggressive-shadows
branch
from
a4aa361 to
8718856
Compare
ditman
reviewed
Mar 20, 2020
| final int alpha = (0.4 * color.alpha).round(); | ||
| context.fillStyle = colorComponentsToCssString(red, green, blue, alpha); | ||
| context.shadowBlur = shadow.blurWidth; | ||
| context.shadowColor = colorToCssString(color.withAlpha(0xff)); |
Member
There was a problem hiding this comment.
Why is this overriding the alpha channel of the shadow color to 0xff?
Can we do this instead?
context.shadowColor = colorToCssString(color);
(Assuming that color has the right alpha value set?)
Contributor
Author
There was a problem hiding this comment.
@hterkelsen, do you recall why this was necessary? FWIW, the shadows look OK to me: https://github.com/flutter/goldens/blob/ae6003206eb721137c20cd56d8d1d8e2a76d6dd1/engine/web/shadows.png
yjbanov
force-pushed
the
aggressive-shadows
branch
from
8718856 to
1344049
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make shadows softer by pre-multiplying the alpha by 0.4 (the number is picked purely empirically by comparing the output with Flutter for desktop).
Fixes flutter/flutter#52734
This PR requires flutter/goldens#84