This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Paragraph.getBoxesForRange uses LineMetrics #16625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
added
affects: text input
platform-web
ferhatb
approved these changes
Feb 14, 2020
Contributor
ferhatb
left a comment
ferhatb
left a comment
There was a problem hiding this comment.
small nit, otherwise LGTM
| return ui.TextBox.fromLTRBD( | ||
| left + line.left, | ||
| top, | ||
| line.width + line.left - right, |
Contributor
There was a problem hiding this comment.
please add comment above explaining why -right
yjbanov
approved these changes
Feb 18, 2020
| // |-------------|------------------|-------------|-----------------| | ||
| // | ||
| // ^^^^^^^^^^^^^ | ||
| // This is the box we want to return. |
| expect(paragraph.getBoxesForRange(0, 0), isEmpty); | ||
| }); | ||
|
|
||
| testEachMeasurement('getBoxesForRange multi-line', () { |
Contributor
There was a problem hiding this comment.
Is it worth adding a test for a ParagraphStyle with maxLines such that the start/end range fall outside the max line bounds?
Contributor
Author
There was a problem hiding this comment.
That's a good corner case to test. I'd like to merge this PR while the tree is green though. So I'll add the maxLines test in a future PR.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 20, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2020
jason-simmons
added a commit
to jason-simmons/flutter
that referenced
this pull request
Feb 21, 2020
2020-02-20 [email protected] Roll fuchsia/sdk/core/linux-amd64 from YPr0t... to CZTpy... (flutter/engine#16708) 2020-02-20 [email protected] Roll src/third_party/skia 2c2db2762809..9d4e31d6cda5 (1 commits) (flutter/engine#16707) 2020-02-20 [email protected] Roll fuchsia/sdk/core/mac-amd64 from WZgbp... to 78ZcV... (flutter/engine#16706) 2020-02-20 [email protected] Roll src/third_party/dart e187e42593e8..81d4cc6bc99a (3 commits) (flutter/engine#16705) 2020-02-20 [email protected] Fix the newline on some keyboards (flutter/engine#16560) 2020-02-20 [email protected] Enable lazy-async-stacks by-default in all modes (flutter/engine#16556) 2020-02-20 [email protected] Roll src/third_party/skia a5097354217b..2c2db2762809 (1 commits) (flutter/engine#16704) 2020-02-20 [email protected] Roll src/third_party/skia ed1ff23c2768..a5097354217b (1 commits) (flutter/engine#16703) 2020-02-20 [email protected] Roll src/third_party/dart 7469b87b042a..e187e42593e8 (11 commits) (flutter/engine#16702) 2020-02-20 [email protected] Roll fuchsia/sdk/core/linux-amd64 from VHyDa... to YPr0t... (flutter/engine#16701) 2020-02-20 [email protected] Roll src/third_party/skia 9baef3593c3c..ed1ff23c2768 (5 commits) (flutter/engine#16699) 2020-02-20 [email protected] Roll src/third_party/skia 7dfb46e7f397..9baef3593c3c (3 commits) (flutter/engine#16696) 2020-02-19 [email protected] fix param (flutter/engine#16694) 2020-02-19 [email protected] Roll src/third_party/dart 0f141be8bd52..7469b87b042a (9 commits) (flutter/engine#16693) 2020-02-19 [email protected] Roll src/third_party/skia c5ff41f2976e..7dfb46e7f397 (20 commits) (flutter/engine#16691) 2020-02-19 [email protected] Roll fuchsia/sdk/core/mac-amd64 from _jvYk... to WZgbp... (flutter/engine#16692) 2020-02-19 [email protected] Revert "Remove usage of Dart_AllocateWithNativeFields from tonic (flutter#16588)" (flutter/engine#16684) 2020-02-19 [email protected] [web] Paragraph.getBoxesForRange uses LineMetrics (flutter/engine#16625) 2020-02-19 [email protected] Roll src/third_party/dart 707ecda05e14..0f141be8bd52 (4 commits) (flutter/engine#16683)
13 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2020
This was referenced Feb 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2020
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
)" This reverts commit 70767fb.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#39826