Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Unskip tests that are already passing in Safari #16567

Merged
mdebbar merged 2 commits into from
Feb 14, 2020
Merged

[web] Unskip tests that are already passing in Safari #16567

mdebbar merged 2 commits into from
Feb 14, 2020

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Feb 12, 2020

Partial fix for flutter/flutter#50596

@mdebbar mdebbar added affects: tests platform-web Code specifically for the web engine labels Feb 12, 2020
@mdebbar mdebbar requested a review from nturgut February 12, 2020 23:16
@mdebbar mdebbar self-assigned this Feb 12, 2020
@mdebbar
Copy link
Contributor Author

mdebbar commented Feb 12, 2020

@nturgut I noticed you skipped many tests in paragraph_test, text_test and measurement_test. But when I unskip and run them locally, most of the tests are passing (except a few that I kept skipped). Were you seeing the failures on your laptop or on LUCI? Could it be that tests are passing locally but failing on LUCI for some reason?

@nturgut
Copy link
Contributor

nturgut commented Feb 13, 2020 •
edited
Loading

@nturgut I noticed you skipped many tests in paragraph_test, text_test and measurement_test. But when I unskip and run them locally, most of the tests are passing (except a few that I kept skipped). Were you seeing the failures on your laptop or on LUCI? Could it be that tests are passing locally but failing on LUCI for some reason?

these are the latest results from LUCI:https://chromium-swarm.appspot.com/task?id=4a5932b58fb0a610 The initial run was made on my local Mac.

@mdebbar
Copy link
Contributor Author

mdebbar commented Feb 14, 2020

@nturgut thanks! The results in LUCI match the results on my macbook.

@mdebbar mdebbar added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 14, 2020
@mdebbar
Copy link
Contributor Author

mdebbar commented Feb 14, 2020

Landing on red. Fuchsia infra is broken, and my changes have nothing to do with Fuchsia.

@mdebbar mdebbar merged commit f88f7df into flutter:master Feb 14, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2020
@engine-flutter-autoroll
f88f7df [web] Unskip tests that are already passing in Safari (flutte…
57b9ea2 
…r/engine#16567)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2020
Merged
jason-simmons pushed a commit to flutter/flutter that referenced this pull request Feb 18, 2020
@engine-flutter-autoroll
Roll engine d60f298..bb01cb7 (11 commits) (#50849)
bcacd06 
* c0549fb Roll buildroot. (flutter/engine#16613)

* 8b0b649 improve surface state assert error messages (flutter/engine#16595)

* cd77e78 Fix drawRRect failure when shader is specified (flutter/engine#16601)

* fe63094 [web] Handle alignment correctly in Paragraph.getPositionForOffset (flutter/engine#16569)

* 65d1126 [web] Fixing launching Safari. This should solve the LUCI issue (flutter/engine#16590)

* f88f7df [web] Unskip tests that are already passing in Safari (flutter/engine#16567)

* 594f660 [shell tests] Integrate Vulkan with Shell Tests

* 400ed7c Revert "[shell tests] Integrate Vulkan with Shell Tests"

* 15e7f51 Implement Path extractPath, tangent APIs (flutter/engine#16599)

* 4941ff7 Remove usage of Dart_AllocateWithNativeFields from tonic (flutter/engine#16588)

* bb01cb7 Roll fuchsia/sdk/core/linux-amd64 from Bmq1m... to J-_s6... (flutter/engine#16592)
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
@mdebbar @NoamDev
[web] Unskip tests that are already passing in Safari (flutter#16567)
221c5bf
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
@NoamDev
Revert "[web] Unskip tests that are already passing in Safari (flutte…
412412c 
…r#16567)"

This reverts commit 221c5bf.
@mdebbar mdebbar deleted the unskip_safari_paragraph_tests branch April 15, 2021 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@nturgut nturgut nturgut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mdebbar mdebbar

Labels

affects: tests cla: yes platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdebbar @nturgut @googlebot