This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix unused import in Android embedder #16494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
android.os.Parcelable was added in commit 6d5aaa0 but never used.
Member
Author
|
Quick cleanup based on an internal roll this morning. |
mklim
approved these changes
Feb 7, 2020
Contributor
mklim
left a comment
mklim
left a comment
There was a problem hiding this comment.
LGTM. Technically all PRs need tests but there is definitely no way to test for this. I think having our existing JUnit test suite build and pass with this PR is enough.
Member
Author
|
Unused import cleanups are technically tested by the compiler itself -- no manual testing required. 😉 |
Member
Author
|
I think the real takeaway here is we should add unused imports linting to our presubmits. Filed flutter/flutter#50353. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 8, 2020
dnfield
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 8, 2020
* c932214 Ensure fields of Rect and OffsetBase classes are optimized as non-null. (flutter/engine#16465) * 5c70356 Simplify task queues locking mechanism (flutter/engine#16477) * d589dde Fix text range logic for a11y (flutter/engine#16496) * 1a4f4e3 Fix unused import in Android embedder (flutter/engine#16494) * 964ae10 Disable ShellTest.WaitForFirstFrameTimeout on Fuchsia (flutter/engine#16495) * 6158f03 Roll src/third_party/skia 87e3bef6f82f..9f3eef796f63 (7 commits) (flutter/engine#16493)
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
android.os.Parcelable was added in commit 6d5aaa0 but never used.
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
This reverts commit f539320.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
android.os.Parcelable was added in commit
6d5aaa0 but never used.