Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@ferhatb
Copy link
Contributor

@ferhatb ferhatb commented Jan 21, 2020

return '"$fontFamily", $_fallbackFontFamily, sans-serif';
}

Float32List offsetListToFloat32List(List<ui.Offset> offsetList) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ferhatb
Copy link
Contributor Author

ferhatb commented Jan 22, 2020

Merging on infra fail.

@ferhatb ferhatb merged commit 3d5bbb4 into flutter:master Jan 22, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2020
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jan 22, 2020
flutter/engine@79f898e...83a64b7

git log 79f898e..83a64b7 --first-parent --oneline
2020-01-22 [email protected] derp (flutter/engine#15876)
2020-01-22 [email protected] Implement Canvas drawPoints API for Html backend (flutter/engine#15870)
2020-01-22 [email protected] retry on CIPD failure (flutter/engine#15862)
2020-01-21 [email protected] Roll src/third_party/skia cedab522227a..4277f0173657 (9 commits) (flutter/engine#15863)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
@ferhatb ferhatb deleted the drawpoints_impl branch March 10, 2020 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants