This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Implement Canvas drawPoints API for Html backend #15870
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryterkelsen
approved these changes
Jan 21, 2020
yjbanov
approved these changes
Jan 21, 2020
| return '"$fontFamily", $_fallbackFontFamily, sans-serif'; | ||
| } | ||
|
|
||
| Float32List offsetListToFloat32List(List<ui.Offset> offsetList) { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Contributor
Author
|
Merging on infra fail. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 22, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 22, 2020
flutter/engine@79f898e...83a64b7 git log 79f898e..83a64b7 --first-parent --oneline 2020-01-22 [email protected] derp (flutter/engine#15876) 2020-01-22 [email protected] Implement Canvas drawPoints API for Html backend (flutter/engine#15870) 2020-01-22 [email protected] retry on CIPD failure (flutter/engine#15862) 2020-01-21 [email protected] Roll src/third_party/skia cedab522227a..4277f0173657 (9 commits) (flutter/engine#15863) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…)" This reverts commit 9febe81.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EAP issue flutter/flutter#32218