Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@tvolkert
Copy link
Contributor

  • google/skia@a640745 Disable QCOM_tiled_rendering while we wait for test devices
  • bcb8267 Revert "Do not default to downstream affinity on iOS insertText"

@tvolkert
Copy link
Contributor Author

@GaryQian
Copy link
Contributor

I believe this engine patch should also be applied: flutter/flutter#45698 it is paired with bcb8267 Revert "Do not default to downstream affinity on iOS insertText"

@tvolkert
Copy link
Contributor Author

@GaryQian it will be, but it's in the other repo and can't be applied here.

@GaryQian
Copy link
Contributor

GaryQian commented Jan 16, 2020

Ok! Didn't see an engine hash so just wanted to make sure!

Edit: Oops totally forgot this IS the engine repo.

Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert tvolkert merged commit a433ed9 into flutter:v1.12.13-hotfixes Jan 17, 2020
@tvolkert tvolkert deleted the v1.12.13-hotfixes branch January 17, 2020 07:06
@zmtzawqlp
Copy link

@GaryQian is there any plan to release this hotfix?

@tvolkert
Copy link
Contributor Author

@zmtzawqlp yes, but we're having trouble getting the requisite artifacts to build successfully.

@godofredoc any luck with the LUCI builders? (I'm currently OOO so can't look)

@godofredoc
Copy link
Contributor

  • The fuchsia failures are because the device is not found within one minute when it is paved, it requires a fix to the fuchsia_ctl and manual validation.

  • The failure in the ios tests is because the upgraded xcode version doesn't contain the ios simulator expected by the test. I'll reach out to the xcode package owners to bundle the expected simulator.

@adham-ashraf77
Copy link

i have a project i want to release please do the fix for Huawei Y7 Prime (2019) Versions: DUB-LX3
the app can't open it crash every time.

@tdesc
Copy link

tdesc commented Jan 20, 2020

Any expected timespan we could get this hotfix in flutter tag?
Our production application with almost 100K users goes a bit wild with Skia bug.

@adham-ashraf77
Copy link

adham-ashraf77 commented Jan 21, 2020

the project we work on we have 150K users and we want the fix to update the project to work on Huawei devices.
@tvolkert

@omarsherifs
Copy link

we need to fix this issue ِASAP because we have 55k users and they can't use our app because of this issue due to the high demand for Huawei phones in this market so most of our users are Huawei or honor users.

Thanks in advance
@tvolkert

@thomas-doussin
Copy link

Same here. Many user complains about our last update due this issue. Huawei, but also Old samsung such as Galaxy Prime. When the hotfix will be available ?

@tvolkert
Copy link
Contributor Author

Sorry everyone - I was out sick the last few days and let this drop. We're picking it back up now. @dnfield is going to cherry-pick another fix into the hotfix and get things underway.

@jcsena
Copy link

jcsena commented Jan 23, 2020

I have solved the problem with the master channel, it is not the better solution, but it is working for me. flutter/flutter#47804 (comment)

@thomas-doussin
Copy link

@tvolkert and @dnfield When the v1.12.13+hotfix.7 will be available ? Sorry to bother you

@tvolkert
Copy link
Contributor Author

@thomas-doussin should be available today

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants